[dpdk-dev] [PATCH] common/mlx5: fix missing __rte_internal tags in exported functions

[Raslan Darawsheh]

Hi,

> -----Original Message-----
> From: Thomas Monjalon <thomas at monjalon.net>
> Sent: Monday, April 12, 2021 3:26 PM
> To: Tal Shnaiderman <talshn at nvidia.com>; Raslan Darawsheh
> <rasland at nvidia.com>
> Cc: dev at dpdk.org; Matan Azrad <matan at nvidia.com>; Asaf Penso
> <asafp at nvidia.com>; Wisam Monther <wisamm at nvidia.com>;
> stable at dpdk.org
> Subject: Re: [PATCH] common/mlx5: fix missing __rte_internal tags in
> exported functions
> 
> 12/04/2021 13:25, Raslan Darawsheh:
> > Removed __ from the commit title to fix wrong headline format issue.
> 
> Removing __ makes it wrong: rte_internal does not exist.
> The idea of discouraging the use of underscore is to avoid
> naming bits and bytes in the title.
> Here it should be: "add missing internal tags to some functions"
My suggestion was to make it like this:
"fix missing rte internal tags in exported functions"

But, I find your suggestion even better, so I'd change it to that

> 
> > > Several functions introduced in the addition of the Windows support to
> > > mlx5 were missing the __rte_internal tag although being exported.
> 
> 
Kindest regards
Raslan Darawsheh