[dpdk-dev] [v3, 0/3] common/cnxk: enable npa telemetry

[Gowrishankar Muthukrishnan]

Hi Ciara,

> -----Original Message-----
> From: Power, Ciara <ciara.power at intel.com>
> Sent: Wednesday, August 11, 2021 9:30 PM
> To: Gowrishankar Muthukrishnan <gmuthukrishn at marvell.com>; dev at dpdk.org
> Cc: Richardson, Bruce <bruce.richardson at intel.com>; Jerin Jacob Kollanukkaran
> <jerinj at marvell.com>; Kiran Kumar Kokkilagadda <kirankumark at marvell.com>;
> Nithin Kumar Dabilpuram <ndabilpuram at marvell.com>; Sunil Kumar Kori
> <skori at marvell.com>; Satha Koteswara Rao Kottidi
> <skoteshwar at marvell.com>
> Subject: [EXT] RE: [v3, 0/3] common/cnxk: enable npa telemetry
> 
> External Email
> 
> ----------------------------------------------------------------------
> Hi Gowrishankar,
> 
> >-----Original Message-----
> >From: Gowrishankar Muthukrishnan <gmuthukrishn at marvell.com>
> >Sent: Tuesday 3 August 2021 09:06
> >To: dev at dpdk.org
> >Cc: Richardson, Bruce <bruce.richardson at intel.com>; Power, Ciara
> ><ciara.power at intel.com>; jerinj at marvell.com; kirankumark at marvell.com;
> >ndabilpuram at marvell.com; skori at marvell.com; skoteshwar at marvell.com;
> >Gowrishankar Muthukrishnan <gmuthukrishn at marvell.com>
> >Subject: [v3, 0/3] common/cnxk: enable npa telemetry
> >
> >This patch series enables telemetry in NPA LF of cnxk.
> >
> >v3:
> > - fixed format specifier for uintptr_t
> >
> >Gowrishankar Muthukrishnan (3):
> >  telemetry: enable storing pointer value
> >  test/telemetry: add unit tests for pointer value
> >  common/cnxk: add telemetry endpoints to npa
> >
> > app/test/test_telemetry_data.c           | 125 +++++++++++++
> > app/test/test_telemetry_json.c           |  29 ++-
> > drivers/common/cnxk/cnxk_telemetry.h     |  26 +++
> > drivers/common/cnxk/cnxk_telemetry_npa.c | 227
> >+++++++++++++++++++++++
> > drivers/common/cnxk/meson.build          |   4 +
> > drivers/common/cnxk/roc_platform.h       |   8 +
> > lib/telemetry/rte_telemetry.h            |  37 +++-
> > lib/telemetry/telemetry.c                |  21 ++-
> > lib/telemetry/telemetry_data.c           |  40 +++-
> > lib/telemetry/telemetry_data.h           |   2 +
> > lib/telemetry/telemetry_json.h           |  32 ++++
> > lib/telemetry/version.map                |   2 +
> > 12 files changed, 539 insertions(+), 14 deletions(-)  create mode
> >100644 drivers/common/cnxk/cnxk_telemetry.h
> > create mode 100644 drivers/common/cnxk/cnxk_telemetry_npa.c
> >
> >--
> >2.25.1
> 
> I am still unsure exactly what the use case is here - why are we choosing to
> publish the pointer values through telemetry rather than using a debug log for
> example?

Pointer values are useful sometimes for more debugging through telemetry, hence this proposal.
As I mentioned in v1 thread, this is architecture compliant approach rather than assuming pointer 
value is always 64 bit, when there is need to use pointer value in current telemetry path.

Thanks,
Gowrishankar

> Maybe I am missing something here.
> 
> Thanks,
> Ciara