[dpdk-dev] [PATCH v3 2/2] net: macro to extract MAC address bytes

Ferruh Yigit ferruh.yigit at intel.com
Thu Aug 12 17:59:46 CEST 2021


On 8/10/2021 8:35 AM, Aman Singh wrote:
> Added macros to simplyfy print of MAC address.

s/simplyfy/simplify

> The other method of first formatting mac address
> into a string and string printed, is avoided.
> 

There are some cases that 'rte_ether_format_addr()' API is used to convert MAC
address into string and later that string is printed. If you mean above usage,
that usage is still exist after this patch. As far as I can see this patch is
just to add helper macro to get octets of the MAC address. Can you please clarify?

> Signed-off-by: Aman Singh <aman.deep.singh at intel.com>
> ---
> The change in the document will be done in seperate patch.
> To ensure document has direct reference of the code.

+1, you can add the link of mentioned patch here.

And patch title comment in previous patch applies here too, can you please
update it?

Except above issues,
Reviewed-by: Ferruh Yigit <ferruh.yigit at intel.com>



More information about the dev mailing list