[dpdk-dev] [PATCH v4 2/2] net: added macro to extract MAC address bytes

[Ferruh Yigit]

On 8/17/2021 12:03 AM, Stephen Hemminger wrote:
> On Mon, 16 Aug 2021 15:27:28 +0530
> Aman Singh <aman.deep.singh at intel.com> wrote:
> 
>> Added macros to simplify print of MAC address.
>> The six bytes of a MAC address are extracted in
>> a macro here, to improve code readablity.
>>
>> Signed-off-by: Aman Singh <aman.deep.singh at intel.com>
>> Reviewed-by: Ferruh Yigit <ferruh.yigit at intel.com>
>> ---
>> The change in the document will be done in seperate patch.
>> To ensure document has direct reference of the code as shown in
>> commit 413c75c33c40 ("doc: show how to include code in guides").
> 
> NAK
> The DPDK already has rte_ether_format_addr()
> why does so much code not use it?
> 

'rte_ether_format_addr()' formats string to a buffer, but most of the times the
need is just to log and having a buffer for it is unnecessary.

Both macros look useful to me.