[PATCH v3 00/25] Net/SPNIC: support SPNIC into DPDK 22.03

[Stephen Hemminger]

On Fri, 24 Dec 2021 16:32:18 +0800
Yanling Song <songyl at ramaxel.com> wrote:

> The patchsets introduce SPNIC driver for Ramaxel's SPNxx serial NIC cards into DPDK 22.03.
> Ramaxel Memory Technology is a company which supply a lot of electric products: 
> storage, communication, PCB...
> SPNxxx is a serial PCIE interface NIC cards:
> SPN110: 2 PORTs *25G
> SPN120: 4 PORTs *25G
> SPN130: 2 PORTs *100G
> 
> The following is main features of our SPNIC:
> - TSO
> - LRO
> - Flow control
> - SR-IOV(Partially supported)
> - VLAN offload
> - VLAN filter
> - CRC offload
> - Promiscuous mode
> - RSS
> 
> v2->v3:
> 1. Fix clang compiling failure.
> 
> v1->v2:
> 1. Fix coding style issues and compiling failures;
> 2. Only support linux in meson.build;
> 3. Use CLOCK_MONOTONIC_COARSE instead of CLOCK_MONOTONIC/CLOCK_MONOTONIC_RAW;
> 4. Fix time_before();
> 5. Remove redundant checks in spnic_dev_configure();

Overall looks good.

Please use a consistent prefix to all globally visible symbols to avoid any
possible name clashes when statically linking.

$ nm ./build/drivers/librte_net_spnic.a |  grep ' t ' | grep -v spnic_ | grep -v rte_
00000000000006f0 t remove_aeq
0000000000000040 t fault_event_handler
0000000000000060 t ffm_event_msg_handler
00000000000016c0 t alloc_mbox_info
0000000000000ca0 t send_mbox_to_func
0000000000000890 t send_tlp_mbox_to_func
00000000000000c0 t pciinitfn_net_spnic
0000000000000890 t clean_queue_offload_ctxt