[dpdk-dev] [PATCH v1 07/20] net/txgbe: add Rx and Tx unit init for VF device

[Ferruh Yigit]

On 1/22/2021 9:47 AM, Jiawen Wu wrote:
> Configure VF device with RX port. Initialize receive and transmit unit,
> set the receive and transmit functions. And support to check the
> status of RX and TX descriptors.
> 
> Signed-off-by: Jiawen Wu <jiawenwu at trustnetic.com>

<...>

> @@ -13,6 +17,9 @@ L3 checksum offload  = P
>   L4 checksum offload  = P
>   Inner L3 checksum    = P
>   Inner L4 checksum    = P
> +Packet type parsing  = Y

Can you please move this where '.dev_supported_ptypes_get' dev_ops set.

<...>

> +static int
> +txgbevf_dev_configure(struct rte_eth_dev *dev)
> +{
> +	struct rte_eth_conf *conf = &dev->data->dev_conf;
> +	struct txgbe_adapter *adapter = TXGBE_DEV_ADAPTER(dev);
> +
> +	PMD_INIT_LOG(DEBUG, "Configured Virtual Function port id: %d",
> +		     dev->data->port_id);
> +
> +	if (dev->data->dev_conf.rxmode.mq_mode & ETH_MQ_RX_RSS_FLAG)
> +		dev->data->dev_conf.rxmode.offloads |= DEV_RX_OFFLOAD_RSS_HASH;
> +
> +	/*
> +	 * VF has no ability to enable/disable HW CRC
> +	 * Keep the persistent behavior the same as Host PF
> +	 */
> +#ifndef RTE_LIBRTE_TXGBE_PF_DISABLE_STRIP_CRC
> +	if (conf->rxmode.offloads & DEV_RX_OFFLOAD_KEEP_CRC) {
> +		PMD_INIT_LOG(NOTICE, "VF can't disable HW CRC Strip");
> +		conf->rxmode.offloads &= ~DEV_RX_OFFLOAD_KEEP_CRC;
> +	}
> +#else
> +	if (!(conf->rxmode.offloads & DEV_RX_OFFLOAD_KEEP_CRC)) {
> +		PMD_INIT_LOG(NOTICE, "VF can't enable HW CRC Strip");
> +		conf->rxmode.offloads |= DEV_RX_OFFLOAD_KEEP_CRC;
> +	}
> +#endif

Is this macro used, if so can you please document it in the driver doc?