[dpdk-dev] [PATCH v2] examples/vhost: fix potentially overflowing expression
Maxime Coquelin
maxime.coquelin at redhat.com
Wed Feb 3 10:54:17 CET 2021
On 2/2/21 8:24 AM, Cheng Jiang wrote:
> Change the type of buff_idx from uint64_t to uint32_t to fix coverity
> issue.
>
> Coverity issue: 366264
> Fixes: a68ba8e0a6b6 ("examples/vhost: refactor vhost data path")
>
> Signed-off-by: Cheng Jiang <Cheng1.jiang at intel.com>
> ---
> v2: fixed the format of git log
>
> examples/vhost/main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/examples/vhost/main.c b/examples/vhost/main.c
> index 233a2dc6e..e74fc8750 100644
> --- a/examples/vhost/main.c
> +++ b/examples/vhost/main.c
> @@ -864,7 +864,7 @@ static __rte_always_inline void
> drain_vhost(struct vhost_dev *vdev)
> {
> uint16_t ret;
> - uint64_t buff_idx = rte_lcore_id() * MAX_VHOST_DEVICE + vdev->vid;
> + uint32_t buff_idx = rte_lcore_id() * MAX_VHOST_DEVICE + vdev->vid;
> uint16_t nr_xmit = vhost_txbuff[buff_idx]->len;
> struct rte_mbuf **m = vhost_txbuff[buff_idx]->m_table;
>
> --
> 2.29.2
>
Reviewed-by: Maxime Coquelin <maxime.coquelin at redhat.com>
Thanks,
Maxime
More information about the dev
mailing list