[dpdk-dev] [PATCH v2] net/pcap: fix infinite Rx with large files

[Ferruh Yigit]

On 2/4/2021 5:02 PM, Ferriter, Cian wrote:
> The new error message looks great.
> 
> As I've already given my ack, I'm happy for this to be applied.
> 
>> -----Original Message-----
>> From: Yigit, Ferruh <ferruh.yigit at intel.com>
>> Sent: Thursday 4 February 2021 16:51
>> To: Ferriter, Cian <cian.ferriter at intel.com>
>> Cc: Yigit, Ferruh <ferruh.yigit at intel.com>; dev at dpdk.org; stable at dpdk.org
>> Subject: [PATCH v2] net/pcap: fix infinite Rx with large files
>>
>> Packet forwarding is not working when infinite Rx feature is used with
>> large .pcap files that has high number of packets.
>>
>> The problem is number of allocated mbufs are less than the infinite Rx
>> ring size, and all mbufs consumed to fill the ring, so there is no mbuf
>> left for forwarding.
>>
>> Current logic can not detect that infinite Rx ring is not filled
>> completely and no more mbufs left, and setup continues which leads
>> silent fail on packet forwarding.
>>
>> There isn't much can be done when there is not enough mbuf for the given
>> .pcap file, so additional checks added to detect the case and fail
>> explicitly with an error log.
>>
>> Bugzilla ID: 595
>> Fixes: a3f5252e5cbd ("net/pcap: enable infinitely Rx a pcap file")
>> Cc: stable at dpdk.org
>>
>> Reported-by: Cian Ferriter <cian.ferriter at intel.com>
>> Signed-off-by: Ferruh Yigit <ferruh.yigit at intel.com>
>> Acked-by: Cian Ferriter <cian.ferriter at intel.com>

Applied to dpdk-next-net/main, thanks.