[dpdk-dev] [PATCH v2 6/13] net/ionic: clean up Tx queue version support

[Thomas Monjalon]

05/02/2021 21:26, Andrew Boyer:
> > On Feb 5, 2021, at 3:20 PM, Thomas Monjalon <thomas at monjalon.net> wrote:
> > 29/01/2021 23:44, Andrew Boyer:
> >> The ionic PMD only supports Tx queue version 1 or greater.
> >> Version 1 introduced a new SGL format with support for more
> >> fragments per descriptor.
> >> 
> >> Add release notes and an explanation to the docs.
> >> 
> >> Signed-off-by: Andrew Boyer <aboyer at pensando.io>
> >> ---
> >> +* **Updated the Pensando ionic driver.**
> >> +
> >> +  Updated the Pensando ionic driver with new features and improvements, including:
> >> +
> >> +  * Fixed bugs related to link autonegotiation.
> >> +  * Fixed bugs related to port start/stop and queue start/stop.
> >> +  * Added support for probing the supported queue versions. Note that
> >> +    extremely old (pre-1.0) firmware will no longer be usable with the PMD.
> >> +  * Removed unused code.
> >> +  * Reduced device startup time.
> > 
> > Most of these items are unrelated to the rest of the patch.
> > And in general we don't mention cleanup and fixes in "New Features".
> > Actually we don't mention such minor things in the release notes.
> 
> It describes all of the changes that went in for this release.

It is recommended to add items in the release notes in the relevant patch
so it allows easy finding of the code mentioned in the release notes.

> Please feel free to remove any you feel are inappropriate - or send me a list and I will send a patch.

It's not a big deal. I am just informing you as you are still quite new :)
The most important is to avoid the release notes becoming a long list of fixes.

Eventually we could remove the lines "Fixed bugs ..." and
"Removed unused code" while doing the last cleanup.