[dpdk-dev] [PATCH v4 1/7] examples/fips_validation: enhance getopt_long usage

David Marchand david.marchand at redhat.com
Thu Feb 18 12:14:03 CET 2021


On Thu, Feb 18, 2021 at 11:48 AM Ibtisam Tariq <ibtisam.tariq at emumba.com> wrote:
> On Thu, Feb 18, 2021 at 2:59 PM David Marchand <david.marchand at redhat.com> wrote:
>>
>> On Thu, Feb 4, 2021 at 8:34 AM Ibtisam Tariq <ibtisam.tariq at emumba.com> wrote:
>> >
>> > Instead of using getopt_long return value, strcmp was used to
>> > compare the input parameters with the struct option array. This
>> > patch get rid of all those strcmp by directly binding each longopt
>> > with an int enum. This is to improve readability and consistency in
>> > all examples.
>> >
>> > Bugzilla ID: 238
>> > Cc: marko.kovacevic at intel.com
>> >
>> > Reported-by: David Marchand <david.marchand at redhat.com>
>> > Signed-off-by: Ibtisam Tariq <ibtisam.tariq at emumba.com>
>>
>> For such a series, please provide a cover letter, this is easier when
>> replying on the whole series (and for me when applying).

Please do not top post.

> Thanks for the recommendation. In future, I will add a cover letter for a long patch set.
> If you want, I can submit the cover letter for this patch set too.

No need to send a new revision just for this, thanks.


-- 
David Marchand



More information about the dev mailing list