[dpdk-dev] [PATCH] devtools: catch symbol duplicates in version map

[Thomas Monjalon]

25/02/2021 12:57, Bruce Richardson:
> On Thu, Feb 25, 2021 at 12:41:16PM +0100, Thomas Monjalon wrote:
> > 25/02/2021 12:14, David Marchand:
> > > Add a check on versioned symbol duplicates in map files.
> > > 
> > > Signed-off-by: David Marchand <david.marchand at redhat.com>
> > > ---
> > > This check could be added to buildtools/check-symbols.sh so that
> > > regular developers catch the issue when building their changes...
> > > Opinions?
> > 
> > In general I am against adding developer tools in the build process,
> > because it could cause more issues for normal users.
> > 
> Is this really likely to cause issues for normal users?

Yes because some users will have a different shell,
or other weird setup we don't think about yet.

> If we add this to
> the build process any issues will surely be caught be developers before
> merge.

If we want the checks to be more popular, we should write a script
to help running the right script at the right time,
and ideally help in the contribution process.