[dpdk-dev] [PATCH] devtools: catch symbol duplicates in version map

[Thomas Monjalon]

25/02/2021 13:05, Bruce Richardson:
> On Thu, Feb 25, 2021 at 01:01:10PM +0100, Thomas Monjalon wrote:
> > 25/02/2021 12:57, Bruce Richardson:
> > > On Thu, Feb 25, 2021 at 12:41:16PM +0100, Thomas Monjalon wrote:
> > > > 25/02/2021 12:14, David Marchand:
> > > > > Add a check on versioned symbol duplicates in map files.
> > > > > 
> > > > > Signed-off-by: David Marchand <david.marchand at redhat.com>
> > > > > ---
> > > > > This check could be added to buildtools/check-symbols.sh so that
> > > > > regular developers catch the issue when building their changes...
> > > > > Opinions?
> > > > 
> > > > In general I am against adding developer tools in the build process,
> > > > because it could cause more issues for normal users.
> > > > 
> > > Is this really likely to cause issues for normal users?
> > 
> > Yes because some users will have a different shell,
> > or other weird setup we don't think about yet.
> > 
> I think it unlikely, but ok.

You would be surprised.
I'm going to send a fix for running buildtools/check-symbols.sh
on busybox.

> Now that meson (from version 0.53 onwards) has a "filesystem" module, with
> an "exists" function, we can perhaps look to introduce a "developer mode"
> build again, based off the presence of the .git folder. Alternatively, we
> could make "developer mode" a regular meson option rather than trying to be
> too smart about it. [Or combine both and have developer mode option with
> "enabled"/"disabled"/"auto-detect" values]

Yes, a developer mode is a good idea.