[dpdk-dev] [PATCH 07/40] net/virtio: move MSIX detection to PCI ethdev

Maxime Coquelin maxime.coquelin at redhat.com
Thu Jan 14 18:19:39 CET 2021



On 1/6/21 9:22 AM, David Marchand wrote:
> On Sun, Dec 20, 2020 at 10:14 PM Maxime Coquelin
> <maxime.coquelin at redhat.com> wrote:
>>
>> There is no point it detecting whether we can use MSIX
>> every time the interrupt is enabled/disabled/masked.
>>
>> Let's do it once for all at PCI device init time.
>>
>> Signed-off-by: Maxime Coquelin <maxime.coquelin at redhat.com>
> 
> Is this a rework/fix of fe19d49cb525 ("net/virtio: fix Rx interrupt
> with VFIO") ?

Hmm, that was only planned as a rework, but it is likely to introduce a
regression by reverting the fix you mention.

I think I'll have to introduce a new callback so that drivers can update
their status.

Good catch, thanks!
Maxime



More information about the dev mailing list