[dpdk-dev] [PATCH v5 7/9] devarg: change representor ID to bitmap

Thomas Monjalon thomas at monjalon.net
Tue Jan 19 09:33:58 CET 2021


19/01/2021 09:20, Andrew Rybchenko:
> On 1/19/21 10:14 AM, Xueming Li wrote:
> > --- a/lib/librte_ethdev/version.map
> > +++ b/lib/librte_ethdev/version.map
> > @@ -257,6 +257,8 @@ INTERNAL {
> >  	rte_eth_dev_release_port;
> >  	rte_eth_dev_internal_reset;
> >  	rte_eth_devargs_parse;
> > +	rte_eth_representor_id_encode;
> > +	rte_eth_representor_id_parse;
> 
> The place looks wrong. It must be sorted or added at bottom
> with the comment with version number. I'd prefer to have
> it simply alphanumberically sorted.

We add a version number for experimental symbols to help
moving old ones to stable.
In this case, they are internal symbols, so we don't need version,
but you're right it must be alphabetically sorted.





More information about the dev mailing list