[dpdk-dev] [PATCH 4/4] ethdev: remove jumbo offload flag
Xu, Rosen
rosen.xu at intel.com
Sun Jul 18 09:53:39 CEST 2021
Hi,
> -----Original Message-----
> From: Yigit, Ferruh <ferruh.yigit at intel.com>
> Sent: Saturday, July 10, 2021 1:29
> To: Jerin Jacob <jerinj at marvell.com>; Li, Xiaoyun <xiaoyun.li at intel.com>;
> Ajit Khaparde <ajit.khaparde at broadcom.com>; Somnath Kotur
> <somnath.kotur at broadcom.com>; Igor Russkikh
> <igor.russkikh at aquantia.com>; Pavel Belous <pavel.belous at aquantia.com>;
> Somalapuram Amaranath <asomalap at amd.com>; Rasesh Mody
> <rmody at marvell.com>; Shahed Shaikh <shshaikh at marvell.com>; Chas
> Williams <chas3 at att.com>; Min Hu (Connor) <humin29 at huawei.com>;
> Nithin Dabilpuram <ndabilpuram at marvell.com>; Kiran Kumar K
> <kirankumark at marvell.com>; Sunil Kumar Kori <skori at marvell.com>; Satha
> Rao <skoteshwar at marvell.com>; Rahul Lakkireddy
> <rahul.lakkireddy at chelsio.com>; Hemant Agrawal
> <hemant.agrawal at nxp.com>; Sachin Saxena <sachin.saxena at oss.nxp.com>;
> Wang, Haiyue <haiyue.wang at intel.com>; Marcin Wojtas
> <mw at semihalf.com>; Michal Krawczyk <mk at semihalf.com>; Guy Tzalik
> <gtzalik at amazon.com>; Evgeny Schemeilin <evgenys at amazon.com>; Igor
> Chauskin <igorch at amazon.com>; Gagandeep Singh <g.singh at nxp.com>;
> Daley, John <johndale at cisco.com>; Hyong Youb Kim <hyonkim at cisco.com>;
> Gaetan Rivet <grive at u256.net>; Zhang, Qi Z <qi.z.zhang at intel.com>; Wang,
> Xiao W <xiao.w.wang at intel.com>; Ziyang Xuan <xuanziyang2 at huawei.com>;
> Xiaoyun Wang <cloud.wangxiaoyun at huawei.com>; Guoyang Zhou
> <zhouguoyang at huawei.com>; Yisen Zhuang <yisen.zhuang at huawei.com>;
> Lijun Ou <oulijun at huawei.com>; Xing, Beilei <beilei.xing at intel.com>; Wu,
> Jingjing <jingjing.wu at intel.com>; Yang, Qiming <qiming.yang at intel.com>;
> Andrew Boyer <aboyer at pensando.io>; Xu, Rosen <rosen.xu at intel.com>;
> Matan Azrad <matan at nvidia.com>; Shahaf Shuler <shahafs at nvidia.com>;
> Viacheslav Ovsiienko <viacheslavo at nvidia.com>; Zyta Szpak
> <zr at semihalf.com>; Liron Himi <lironh at marvell.com>; Heinrich Kuhn
> <heinrich.kuhn at netronome.com>; Harman Kalra <hkalra at marvell.com>;
> Nalla Pradeep <pnalla at marvell.com>; Radha Mohan Chintakuntla
> <radhac at marvell.com>; Veerasenareddy Burru <vburru at marvell.com>;
> Devendra Singh Rawat <dsinghrawat at marvell.com>; Andrew Rybchenko
> <andrew.rybchenko at oktetlabs.ru>; Maciej Czekaj <mczekaj at marvell.com>;
> Jiawen Wu <jiawenwu at trustnetic.com>; Jian Wang
> <jianwang at trustnetic.com>; Maxime Coquelin
> <maxime.coquelin at redhat.com>; Xia, Chenbo <chenbo.xia at intel.com>;
> Yong Wang <yongwang at vmware.com>; Ananyev, Konstantin
> <konstantin.ananyev at intel.com>; Nicolau, Radu <radu.nicolau at intel.com>;
> Akhil Goyal <gakhil at marvell.com>; Hunt, David <david.hunt at intel.com>;
> Mcnamara, John <john.mcnamara at intel.com>; Thomas Monjalon
> <thomas at monjalon.net>
> Cc: Yigit, Ferruh <ferruh.yigit at intel.com>; dev at dpdk.org
> Subject: [PATCH 4/4] ethdev: remove jumbo offload flag
>
> Removing 'DEV_RX_OFFLOAD_JUMBO_FRAME' offload flag.
>
> Instead of drivers announce this capability, application can deduct the
> capability by checking reported 'dev_info.max_mtu' or
> 'dev_info.max_rx_pktlen'.
>
> And instead of application explicitly set this flag to enable jumbo
> frames, this can be deducted by driver by comparing requested 'mtu' to
> 'RTE_ETHER_MTU'.
>
> Removing this additional configuration for simplification.
>
> Signed-off-by: Ferruh Yigit <ferruh.yigit at intel.com>
> ---
> app/test-eventdev/test_pipeline_common.c | 2 -
> app/test-pmd/cmdline.c | 2 +-
> app/test-pmd/config.c | 24 +---------
> app/test-pmd/testpmd.c | 46 +------------------
> app/test-pmd/testpmd.h | 2 +-
> doc/guides/howto/debug_troubleshoot.rst | 2 -
> doc/guides/nics/bnxt.rst | 1 -
> doc/guides/nics/features.rst | 3 +-
> drivers/net/atlantic/atl_ethdev.c | 1 -
> drivers/net/axgbe/axgbe_ethdev.c | 1 -
> drivers/net/bnx2x/bnx2x_ethdev.c | 1 -
> drivers/net/bnxt/bnxt.h | 1 -
> drivers/net/bnxt/bnxt_ethdev.c | 10 +---
> drivers/net/bonding/rte_eth_bond_pmd.c | 8 ----
> drivers/net/cnxk/cnxk_ethdev.h | 5 +-
> drivers/net/cnxk/cnxk_ethdev_ops.c | 1 -
> drivers/net/cxgbe/cxgbe.h | 1 -
> drivers/net/cxgbe/cxgbe_ethdev.c | 8 ----
> drivers/net/cxgbe/sge.c | 5 +-
> drivers/net/dpaa/dpaa_ethdev.c | 2 -
> drivers/net/dpaa2/dpaa2_ethdev.c | 2 -
> drivers/net/e1000/e1000_ethdev.h | 4 +-
> drivers/net/e1000/em_ethdev.c | 4 +-
> drivers/net/e1000/em_rxtx.c | 19 +++-----
> drivers/net/e1000/igb_rxtx.c | 3 +-
> drivers/net/ena/ena_ethdev.c | 2 -
> drivers/net/enetc/enetc_ethdev.c | 3 +-
> drivers/net/enic/enic_res.c | 1 -
> drivers/net/failsafe/failsafe_ops.c | 2 -
> drivers/net/fm10k/fm10k_ethdev.c | 1 -
> drivers/net/hinic/hinic_pmd_ethdev.c | 1 -
> drivers/net/hns3/hns3_ethdev.c | 1 -
> drivers/net/hns3/hns3_ethdev_vf.c | 1 -
> drivers/net/i40e/i40e_ethdev.c | 1 -
> drivers/net/i40e/i40e_ethdev_vf.c | 3 +-
> drivers/net/i40e/i40e_rxtx.c | 2 +-
> drivers/net/iavf/iavf_ethdev.c | 3 +-
> drivers/net/ice/ice_dcf_ethdev.c | 3 +-
> drivers/net/ice/ice_dcf_vf_representor.c | 1 -
> drivers/net/ice/ice_ethdev.c | 1 -
> drivers/net/ice/ice_rxtx.c | 3 +-
> drivers/net/igc/igc_ethdev.h | 1 -
> drivers/net/igc/igc_txrx.c | 2 +-
> drivers/net/ionic/ionic_ethdev.c | 1 -
> drivers/net/ipn3ke/ipn3ke_representor.c | 3 +-
> drivers/net/ixgbe/ixgbe_ethdev.c | 5 +-
> drivers/net/ixgbe/ixgbe_pf.c | 9 +---
> drivers/net/ixgbe/ixgbe_rxtx.c | 3 +-
> drivers/net/mlx4/mlx4_rxq.c | 1 -
> drivers/net/mlx5/mlx5_rxq.c | 1 -
> drivers/net/mvneta/mvneta_ethdev.h | 3 +-
> drivers/net/mvpp2/mrvl_ethdev.c | 1 -
> drivers/net/nfp/nfp_net.c | 6 +--
> drivers/net/octeontx/octeontx_ethdev.h | 1 -
> drivers/net/octeontx2/otx2_ethdev.h | 1 -
> drivers/net/octeontx_ep/otx_ep_ethdev.c | 3 +-
> drivers/net/octeontx_ep/otx_ep_rxtx.c | 6 ---
> drivers/net/qede/qede_ethdev.c | 1 -
> drivers/net/sfc/sfc_rx.c | 2 -
> drivers/net/thunderx/nicvf_ethdev.h | 1 -
> drivers/net/txgbe/txgbe_rxtx.c | 1 -
> drivers/net/virtio/virtio_ethdev.c | 1 -
> drivers/net/vmxnet3/vmxnet3_ethdev.c | 1 -
> examples/ip_fragmentation/main.c | 3 +-
> examples/ip_reassembly/main.c | 3 +-
> examples/ipsec-secgw/ipsec-secgw.c | 2 -
> examples/ipv4_multicast/main.c | 1 -
> examples/kni/main.c | 5 --
> examples/l3fwd-acl/main.c | 2 -
> examples/l3fwd-graph/main.c | 1 -
> examples/l3fwd-power/main.c | 2 -
> examples/l3fwd/main.c | 1 -
> .../performance-thread/l3fwd-thread/main.c | 2 -
> examples/vhost/main.c | 2 -
> lib/ethdev/rte_ethdev.c | 26 +----------
> lib/ethdev/rte_ethdev.h | 1 -
> 76 files changed, 42 insertions(+), 250 deletions(-)
>
> diff --git a/app/test-eventdev/test_pipeline_common.c b/app/test-
> eventdev/test_pipeline_common.c
> index 5fcea74b4d43..2775e72c580d 100644
> --- a/app/test-eventdev/test_pipeline_common.c
> +++ b/app/test-eventdev/test_pipeline_common.c
> @@ -199,8 +199,6 @@ pipeline_ethdev_setup(struct evt_test *test, struct
> evt_options *opt)
>
> port_conf.rxmode.mtu = opt->max_pkt_sz - RTE_ETHER_HDR_LEN -
> RTE_ETHER_CRC_LEN;
> - if (port_conf.rxmode.mtu > RTE_ETHER_MTU)
> - port_conf.rxmode.offloads |=
> DEV_RX_OFFLOAD_JUMBO_FRAME;
>
> t->internal_port = 1;
> RTE_ETH_FOREACH_DEV(i) {
> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
> index 8bdc042f6e8e..c0b6132d64e8 100644
> --- a/app/test-pmd/cmdline.c
> +++ b/app/test-pmd/cmdline.c
> @@ -1921,7 +1921,7 @@ cmd_config_max_pkt_len_parsed(void
> *parsed_result,
> return;
> }
>
> - update_jumbo_frame_offload(port_id, res->value);
> + update_mtu_from_frame_size(port_id, res->value);
> }
>
> init_port_config();
> diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
> index a87265d7638b..23a48557b676 100644
> --- a/app/test-pmd/config.c
> +++ b/app/test-pmd/config.c
> @@ -1136,39 +1136,19 @@ port_reg_set(portid_t port_id, uint32_t reg_off,
> uint32_t reg_v)
> void
> port_mtu_set(portid_t port_id, uint16_t mtu)
> {
> + struct rte_port *port = &ports[port_id];
> int diag;
> - struct rte_port *rte_port = &ports[port_id];
> - struct rte_eth_dev_info dev_info;
> - int ret;
>
> if (port_id_is_invalid(port_id, ENABLED_WARN))
> return;
>
> - ret = eth_dev_info_get_print_err(port_id, &dev_info);
> - if (ret != 0)
> - return;
> -
> - if (mtu > dev_info.max_mtu || mtu < dev_info.min_mtu) {
> - printf("Set MTU failed. MTU:%u is not in valid range, min:%u
> - max:%u\n",
> - mtu, dev_info.min_mtu, dev_info.max_mtu);
> - return;
> - }
> diag = rte_eth_dev_set_mtu(port_id, mtu);
> if (diag) {
> printf("Set MTU failed. diag=%d\n", diag);
> return;
> }
>
> - rte_port->dev_conf.rxmode.mtu = mtu;
> -
> - if (dev_info.rx_offload_capa & DEV_RX_OFFLOAD_JUMBO_FRAME)
> {
> - if (mtu > RTE_ETHER_MTU) {
> - rte_port->dev_conf.rxmode.offloads |=
> -
> DEV_RX_OFFLOAD_JUMBO_FRAME;
> - } else
> - rte_port->dev_conf.rxmode.offloads &=
> -
> ~DEV_RX_OFFLOAD_JUMBO_FRAME;
> - }
> + port->dev_conf.rxmode.mtu = mtu;
> }
>
> /* Generic flow management functions. */
> diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
> index 2c79cae05664..92feadefab59 100644
> --- a/app/test-pmd/testpmd.c
> +++ b/app/test-pmd/testpmd.c
> @@ -1473,11 +1473,6 @@ init_config(void)
> rte_exit(EXIT_FAILURE,
> "rte_eth_dev_info_get() failed\n");
>
> - ret = update_jumbo_frame_offload(pid, 0);
> - if (ret != 0)
> - printf("Updating jumbo frame offload failed for
> port %u\n",
> - pid);
> -
> if (!(port->dev_info.tx_offload_capa &
> DEV_TX_OFFLOAD_MBUF_FAST_FREE))
> port->dev_conf.txmode.offloads &=
> @@ -3364,24 +3359,18 @@ rxtx_port_config(struct rte_port *port)
> }
>
> /*
> - * Helper function to arrange max_rx_pktlen value and JUMBO_FRAME
> offload,
> - * MTU is also aligned.
> + * Helper function to set MTU from frame size
> *
> * port->dev_info should be set before calling this function.
> *
> - * if 'max_rx_pktlen' is zero, it is set to current device value, "MTU +
> - * ETH_OVERHEAD". This is useful to update flags but not MTU value.
> - *
> * return 0 on success, negative on error
> */
> int
> -update_jumbo_frame_offload(portid_t portid, uint32_t max_rx_pktlen)
> +update_mtu_from_frame_size(portid_t portid, uint32_t max_rx_pktlen)
> {
> struct rte_port *port = &ports[portid];
> uint32_t eth_overhead;
> - uint64_t rx_offloads;
> uint16_t mtu, new_mtu;
> - bool on;
>
> eth_overhead = get_eth_overhead(&port->dev_info);
>
> @@ -3390,39 +3379,8 @@ update_jumbo_frame_offload(portid_t portid,
> uint32_t max_rx_pktlen)
> return -1;
> }
>
> - if (max_rx_pktlen == 0)
> - max_rx_pktlen = mtu + eth_overhead;
> -
> - rx_offloads = port->dev_conf.rxmode.offloads;
> new_mtu = max_rx_pktlen - eth_overhead;
>
> - if (new_mtu <= RTE_ETHER_MTU) {
> - rx_offloads &= ~DEV_RX_OFFLOAD_JUMBO_FRAME;
> - on = false;
> - } else {
> - if ((port->dev_info.rx_offload_capa &
> DEV_RX_OFFLOAD_JUMBO_FRAME) == 0) {
> - printf("Frame size (%u) is not supported by
> port %u\n",
> - max_rx_pktlen, portid);
> - return -1;
> - }
> - rx_offloads |= DEV_RX_OFFLOAD_JUMBO_FRAME;
> - on = true;
> - }
> -
> - if (rx_offloads != port->dev_conf.rxmode.offloads) {
> - uint16_t qid;
> -
> - port->dev_conf.rxmode.offloads = rx_offloads;
> -
> - /* Apply JUMBO_FRAME offload configuration to Rx queue(s)
> */
> - for (qid = 0; qid < port->dev_info.nb_rx_queues; qid++) {
> - if (on)
> - port->rx_conf[qid].offloads |=
> DEV_RX_OFFLOAD_JUMBO_FRAME;
> - else
> - port->rx_conf[qid].offloads &=
> ~DEV_RX_OFFLOAD_JUMBO_FRAME;
> - }
> - }
> -
> if (mtu == new_mtu)
> return 0;
>
> diff --git a/app/test-pmd/testpmd.h b/app/test-pmd/testpmd.h
> index 42143f85924f..b94bf668dc4d 100644
> --- a/app/test-pmd/testpmd.h
> +++ b/app/test-pmd/testpmd.h
> @@ -1012,7 +1012,7 @@ uint16_t tx_pkt_set_dynf(uint16_t port_id,
> __rte_unused uint16_t queue,
> __rte_unused void *user_param);
> void add_tx_dynf_callback(portid_t portid);
> void remove_tx_dynf_callback(portid_t portid);
> -int update_jumbo_frame_offload(portid_t portid, uint32_t max_rx_pktlen);
> +int update_mtu_from_frame_size(portid_t portid, uint32_t
> max_rx_pktlen);
>
> /*
> * Work-around of a compilation error with ICC on invocations of the
> diff --git a/doc/guides/howto/debug_troubleshoot.rst
> b/doc/guides/howto/debug_troubleshoot.rst
> index 457ac441429a..df69fa8bcc24 100644
> --- a/doc/guides/howto/debug_troubleshoot.rst
> +++ b/doc/guides/howto/debug_troubleshoot.rst
> @@ -71,8 +71,6 @@ RX Port and associated core :numref:`dtg_rx_rate`.
> * Identify if port Speed and Duplex is matching to desired values with
> ``rte_eth_link_get``.
>
> - * Check ``DEV_RX_OFFLOAD_JUMBO_FRAME`` is set with
> ``rte_eth_dev_info_get``.
> -
> * Check promiscuous mode if the drops do not occur for unique MAC
> address
> with ``rte_eth_promiscuous_get``.
>
> diff --git a/doc/guides/nics/bnxt.rst b/doc/guides/nics/bnxt.rst
> index feb0c6a7657a..e6f1628402fc 100644
> --- a/doc/guides/nics/bnxt.rst
> +++ b/doc/guides/nics/bnxt.rst
> @@ -886,7 +886,6 @@ processing. This improved performance is derived
> from a number of optimizations:
>
> DEV_RX_OFFLOAD_VLAN_STRIP
> DEV_RX_OFFLOAD_KEEP_CRC
> - DEV_RX_OFFLOAD_JUMBO_FRAME
> DEV_RX_OFFLOAD_IPV4_CKSUM
> DEV_RX_OFFLOAD_UDP_CKSUM
> DEV_RX_OFFLOAD_TCP_CKSUM
> diff --git a/doc/guides/nics/features.rst b/doc/guides/nics/features.rst
> index c98242f3b72f..a077c30644d2 100644
> --- a/doc/guides/nics/features.rst
> +++ b/doc/guides/nics/features.rst
> @@ -165,8 +165,7 @@ Jumbo frame
>
> Supports Rx jumbo frames.
>
> -* **[uses] rte_eth_rxconf,rte_eth_rxmode**:
> ``offloads:DEV_RX_OFFLOAD_JUMBO_FRAME``.
> - ``dev_conf.rxmode.mtu``.
> +* **[uses] rte_eth_rxconf,rte_eth_rxmode**: ``dev_conf.rxmode.mtu``.
> * **[related] rte_eth_dev_info**: ``max_rx_pktlen``.
> * **[related] API**: ``rte_eth_dev_set_mtu()``.
>
> diff --git a/drivers/net/atlantic/atl_ethdev.c
> b/drivers/net/atlantic/atl_ethdev.c
> index 3f654c071566..5a198f53fce7 100644
> --- a/drivers/net/atlantic/atl_ethdev.c
> +++ b/drivers/net/atlantic/atl_ethdev.c
> @@ -158,7 +158,6 @@ static struct rte_pci_driver rte_atl_pmd = {
> | DEV_RX_OFFLOAD_IPV4_CKSUM \
> | DEV_RX_OFFLOAD_UDP_CKSUM \
> | DEV_RX_OFFLOAD_TCP_CKSUM \
> - | DEV_RX_OFFLOAD_JUMBO_FRAME \
> | DEV_RX_OFFLOAD_MACSEC_STRIP \
> | DEV_RX_OFFLOAD_VLAN_FILTER)
>
> diff --git a/drivers/net/axgbe/axgbe_ethdev.c
> b/drivers/net/axgbe/axgbe_ethdev.c
> index c36cd7b1d2f0..0bc9e5eeeb10 100644
> --- a/drivers/net/axgbe/axgbe_ethdev.c
> +++ b/drivers/net/axgbe/axgbe_ethdev.c
> @@ -1217,7 +1217,6 @@ axgbe_dev_info_get(struct rte_eth_dev *dev,
> struct rte_eth_dev_info *dev_info)
> DEV_RX_OFFLOAD_IPV4_CKSUM |
> DEV_RX_OFFLOAD_UDP_CKSUM |
> DEV_RX_OFFLOAD_TCP_CKSUM |
> - DEV_RX_OFFLOAD_JUMBO_FRAME |
> DEV_RX_OFFLOAD_SCATTER |
> DEV_RX_OFFLOAD_KEEP_CRC;
>
> diff --git a/drivers/net/bnx2x/bnx2x_ethdev.c
> b/drivers/net/bnx2x/bnx2x_ethdev.c
> index 009a94e9a8fa..50ff04bb2241 100644
> --- a/drivers/net/bnx2x/bnx2x_ethdev.c
> +++ b/drivers/net/bnx2x/bnx2x_ethdev.c
> @@ -535,7 +535,6 @@ bnx2x_dev_infos_get(struct rte_eth_dev *dev,
> struct rte_eth_dev_info *dev_info)
> dev_info->max_rx_pktlen = BNX2X_MAX_RX_PKT_LEN;
> dev_info->max_mac_addrs = BNX2X_MAX_MAC_ADDRS;
> dev_info->speed_capa = ETH_LINK_SPEED_10G |
> ETH_LINK_SPEED_20G;
> - dev_info->rx_offload_capa = DEV_RX_OFFLOAD_JUMBO_FRAME;
>
> dev_info->rx_desc_lim.nb_max = MAX_RX_AVAIL;
> dev_info->rx_desc_lim.nb_min = MIN_RX_SIZE_NONTPA;
> diff --git a/drivers/net/bnxt/bnxt.h b/drivers/net/bnxt/bnxt.h
> index e93a7eb933b4..9ad7821b4736 100644
> --- a/drivers/net/bnxt/bnxt.h
> +++ b/drivers/net/bnxt/bnxt.h
> @@ -591,7 +591,6 @@ struct bnxt_rep_info {
> DEV_RX_OFFLOAD_TCP_CKSUM | \
> DEV_RX_OFFLOAD_OUTER_IPV4_CKSUM
> | \
> DEV_RX_OFFLOAD_OUTER_UDP_CKSUM
> | \
> - DEV_RX_OFFLOAD_JUMBO_FRAME | \
> DEV_RX_OFFLOAD_KEEP_CRC | \
> DEV_RX_OFFLOAD_VLAN_EXTEND | \
> DEV_RX_OFFLOAD_TCP_LRO | \
> diff --git a/drivers/net/bnxt/bnxt_ethdev.c
> b/drivers/net/bnxt/bnxt_ethdev.c
> index 1e7da8ba61a6..c4fd27bd92de 100644
> --- a/drivers/net/bnxt/bnxt_ethdev.c
> +++ b/drivers/net/bnxt/bnxt_ethdev.c
> @@ -728,15 +728,10 @@ static int bnxt_start_nic(struct bnxt *bp)
> unsigned int i, j;
> int rc;
>
> - if (bp->eth_dev->data->mtu > RTE_ETHER_MTU) {
> - bp->eth_dev->data->dev_conf.rxmode.offloads |=
> - DEV_RX_OFFLOAD_JUMBO_FRAME;
> + if (bp->eth_dev->data->mtu > RTE_ETHER_MTU)
> bp->flags |= BNXT_FLAG_JUMBO;
> - } else {
> - bp->eth_dev->data->dev_conf.rxmode.offloads &=
> - ~DEV_RX_OFFLOAD_JUMBO_FRAME;
> + else
> bp->flags &= ~BNXT_FLAG_JUMBO;
> - }
>
> /* THOR does not support ring groups.
> * But we will use the array to save RSS context IDs.
> @@ -1221,7 +1216,6 @@ bnxt_receive_function(struct rte_eth_dev
> *eth_dev)
> if (eth_dev->data->dev_conf.rxmode.offloads &
> ~(DEV_RX_OFFLOAD_VLAN_STRIP |
> DEV_RX_OFFLOAD_KEEP_CRC |
> - DEV_RX_OFFLOAD_JUMBO_FRAME |
> DEV_RX_OFFLOAD_IPV4_CKSUM |
> DEV_RX_OFFLOAD_UDP_CKSUM |
> DEV_RX_OFFLOAD_TCP_CKSUM |
> diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c
> b/drivers/net/bonding/rte_eth_bond_pmd.c
> index b2a1833e3f91..844ac1581a61 100644
> --- a/drivers/net/bonding/rte_eth_bond_pmd.c
> +++ b/drivers/net/bonding/rte_eth_bond_pmd.c
> @@ -1731,14 +1731,6 @@ slave_configure(struct rte_eth_dev
> *bonded_eth_dev,
> slave_eth_dev->data->dev_conf.rxmode.mtu =
> bonded_eth_dev->data->dev_conf.rxmode.mtu;
>
> - if (bonded_eth_dev->data->dev_conf.rxmode.offloads &
> - DEV_RX_OFFLOAD_JUMBO_FRAME)
> - slave_eth_dev->data->dev_conf.rxmode.offloads |=
> - DEV_RX_OFFLOAD_JUMBO_FRAME;
> - else
> - slave_eth_dev->data->dev_conf.rxmode.offloads &=
> - ~DEV_RX_OFFLOAD_JUMBO_FRAME;
> -
> nb_rx_queues = bonded_eth_dev->data->nb_rx_queues;
> nb_tx_queues = bonded_eth_dev->data->nb_tx_queues;
>
> diff --git a/drivers/net/cnxk/cnxk_ethdev.h
> b/drivers/net/cnxk/cnxk_ethdev.h
> index 4eead0390532..aa147eee45c9 100644
> --- a/drivers/net/cnxk/cnxk_ethdev.h
> +++ b/drivers/net/cnxk/cnxk_ethdev.h
> @@ -75,9 +75,8 @@
> #define CNXK_NIX_RX_OFFLOAD_CAPA \
> (DEV_RX_OFFLOAD_CHECKSUM | DEV_RX_OFFLOAD_SCTP_CKSUM
> | \
> DEV_RX_OFFLOAD_OUTER_IPV4_CKSUM |
> DEV_RX_OFFLOAD_SCATTER | \
> - DEV_RX_OFFLOAD_JUMBO_FRAME |
> DEV_RX_OFFLOAD_OUTER_UDP_CKSUM | \
> - DEV_RX_OFFLOAD_RSS_HASH | DEV_RX_OFFLOAD_TIMESTAMP |
> \
> - DEV_RX_OFFLOAD_VLAN_STRIP)
> + DEV_RX_OFFLOAD_OUTER_UDP_CKSUM |
> DEV_RX_OFFLOAD_RSS_HASH | \
> + DEV_RX_OFFLOAD_TIMESTAMP | DEV_RX_OFFLOAD_VLAN_STRIP)
>
> #define RSS_IPV4_ENABLE \
> (ETH_RSS_IPV4 | ETH_RSS_FRAG_IPV4 |
> ETH_RSS_NONFRAG_IPV4_UDP | \
> diff --git a/drivers/net/cnxk/cnxk_ethdev_ops.c
> b/drivers/net/cnxk/cnxk_ethdev_ops.c
> index 349896f6a1bf..d0924df76152 100644
> --- a/drivers/net/cnxk/cnxk_ethdev_ops.c
> +++ b/drivers/net/cnxk/cnxk_ethdev_ops.c
> @@ -92,7 +92,6 @@ cnxk_nix_rx_burst_mode_get(struct rte_eth_dev
> *eth_dev, uint16_t queue_id,
> {DEV_RX_OFFLOAD_HEADER_SPLIT, " Header Split,"},
> {DEV_RX_OFFLOAD_VLAN_FILTER, " VLAN Filter,"},
> {DEV_RX_OFFLOAD_VLAN_EXTEND, " VLAN Extend,"},
> - {DEV_RX_OFFLOAD_JUMBO_FRAME, " Jumbo Frame,"},
> {DEV_RX_OFFLOAD_SCATTER, " Scattered,"},
> {DEV_RX_OFFLOAD_TIMESTAMP, " Timestamp,"},
> {DEV_RX_OFFLOAD_SECURITY, " Security,"},
> diff --git a/drivers/net/cxgbe/cxgbe.h b/drivers/net/cxgbe/cxgbe.h
> index 7c89a028bf16..37625c5bfb69 100644
> --- a/drivers/net/cxgbe/cxgbe.h
> +++ b/drivers/net/cxgbe/cxgbe.h
> @@ -51,7 +51,6 @@
> DEV_RX_OFFLOAD_IPV4_CKSUM | \
> DEV_RX_OFFLOAD_UDP_CKSUM | \
> DEV_RX_OFFLOAD_TCP_CKSUM | \
> - DEV_RX_OFFLOAD_JUMBO_FRAME | \
> DEV_RX_OFFLOAD_SCATTER | \
> DEV_RX_OFFLOAD_RSS_HASH)
>
> diff --git a/drivers/net/cxgbe/cxgbe_ethdev.c
> b/drivers/net/cxgbe/cxgbe_ethdev.c
> index 70b879fed100..1374f32b6826 100644
> --- a/drivers/net/cxgbe/cxgbe_ethdev.c
> +++ b/drivers/net/cxgbe/cxgbe_ethdev.c
> @@ -661,14 +661,6 @@ int cxgbe_dev_rx_queue_setup(struct rte_eth_dev
> *eth_dev,
> if ((&rxq->fl) != NULL)
> rxq->fl.size = temp_nb_desc;
>
> - /* Set to jumbo mode if necessary */
> - if (eth_dev->data->mtu > RTE_ETHER_MTU)
> - eth_dev->data->dev_conf.rxmode.offloads |=
> - DEV_RX_OFFLOAD_JUMBO_FRAME;
> - else
> - eth_dev->data->dev_conf.rxmode.offloads &=
> - ~DEV_RX_OFFLOAD_JUMBO_FRAME;
> -
> err = t4_sge_alloc_rxq(adapter, &rxq->rspq, false, eth_dev, msi_idx,
> &rxq->fl, NULL,
> is_pf4(adapter) ?
> diff --git a/drivers/net/cxgbe/sge.c b/drivers/net/cxgbe/sge.c
> index 830f5192474d..21b8fe61c9a7 100644
> --- a/drivers/net/cxgbe/sge.c
> +++ b/drivers/net/cxgbe/sge.c
> @@ -365,13 +365,10 @@ static unsigned int refill_fl_usembufs(struct
> adapter *adap, struct sge_fl *q,
> struct rte_mbuf *buf_bulk[n];
> int ret, i;
> struct rte_pktmbuf_pool_private *mbp_priv;
> - u8 jumbo_en = rxq->rspq.eth_dev->data-
> >dev_conf.rxmode.offloads &
> - DEV_RX_OFFLOAD_JUMBO_FRAME;
>
> /* Use jumbo mtu buffers if mbuf data room size can fit jumbo data.
> */
> mbp_priv = rte_mempool_get_priv(rxq->rspq.mb_pool);
> - if (jumbo_en &&
> - ((mbp_priv->mbuf_data_room_size -
> RTE_PKTMBUF_HEADROOM) >= 9000))
> + if ((mbp_priv->mbuf_data_room_size -
> RTE_PKTMBUF_HEADROOM) >= 9000)
> buf_size_idx = RX_LARGE_MTU_BUF;
>
> ret = rte_mempool_get_bulk(rxq->rspq.mb_pool, (void *)buf_bulk,
> n);
> diff --git a/drivers/net/dpaa/dpaa_ethdev.c
> b/drivers/net/dpaa/dpaa_ethdev.c
> index 60dd4f67fc26..9cc808b767ea 100644
> --- a/drivers/net/dpaa/dpaa_ethdev.c
> +++ b/drivers/net/dpaa/dpaa_ethdev.c
> @@ -54,7 +54,6 @@
>
> /* Supported Rx offloads */
> static uint64_t dev_rx_offloads_sup =
> - DEV_RX_OFFLOAD_JUMBO_FRAME |
> DEV_RX_OFFLOAD_SCATTER;
>
> /* Rx offloads which cannot be disabled */
> @@ -592,7 +591,6 @@ dpaa_dev_rx_burst_mode_get(struct rte_eth_dev
> *dev,
> uint64_t flags;
> const char *output;
> } rx_offload_map[] = {
> - {DEV_RX_OFFLOAD_JUMBO_FRAME, " Jumbo
> frame,"},
> {DEV_RX_OFFLOAD_SCATTER, " Scattered,"},
> {DEV_RX_OFFLOAD_IPV4_CKSUM, " IPV4 csum,"},
> {DEV_RX_OFFLOAD_UDP_CKSUM, " UDP csum,"},
> diff --git a/drivers/net/dpaa2/dpaa2_ethdev.c
> b/drivers/net/dpaa2/dpaa2_ethdev.c
> index 6b44b0557e6a..53508972a4c2 100644
> --- a/drivers/net/dpaa2/dpaa2_ethdev.c
> +++ b/drivers/net/dpaa2/dpaa2_ethdev.c
> @@ -44,7 +44,6 @@ static uint64_t dev_rx_offloads_sup =
> DEV_RX_OFFLOAD_OUTER_UDP_CKSUM |
> DEV_RX_OFFLOAD_VLAN_STRIP |
> DEV_RX_OFFLOAD_VLAN_FILTER |
> - DEV_RX_OFFLOAD_JUMBO_FRAME |
> DEV_RX_OFFLOAD_TIMESTAMP;
>
> /* Rx offloads which cannot be disabled */
> @@ -298,7 +297,6 @@ dpaa2_dev_rx_burst_mode_get(struct rte_eth_dev
> *dev,
> {DEV_RX_OFFLOAD_OUTER_UDP_CKSUM, " Outer
> UDP csum,"},
> {DEV_RX_OFFLOAD_VLAN_STRIP, " VLAN strip,"},
> {DEV_RX_OFFLOAD_VLAN_FILTER, " VLAN filter,"},
> - {DEV_RX_OFFLOAD_JUMBO_FRAME, " Jumbo
> frame,"},
> {DEV_RX_OFFLOAD_TIMESTAMP, " Timestamp,"},
> {DEV_RX_OFFLOAD_RSS_HASH, " RSS,"},
> {DEV_RX_OFFLOAD_SCATTER, " Scattered,"}
> diff --git a/drivers/net/e1000/e1000_ethdev.h
> b/drivers/net/e1000/e1000_ethdev.h
> index 3b4d9c3ee6f4..1ae78fe71f02 100644
> --- a/drivers/net/e1000/e1000_ethdev.h
> +++ b/drivers/net/e1000/e1000_ethdev.h
> @@ -468,8 +468,8 @@ void eth_em_rx_queue_release(void *rxq);
> void em_dev_clear_queues(struct rte_eth_dev *dev);
> void em_dev_free_queues(struct rte_eth_dev *dev);
>
> -uint64_t em_get_rx_port_offloads_capa(struct rte_eth_dev *dev);
> -uint64_t em_get_rx_queue_offloads_capa(struct rte_eth_dev *dev);
> +uint64_t em_get_rx_port_offloads_capa(void);
> +uint64_t em_get_rx_queue_offloads_capa(void);
>
> int eth_em_rx_queue_setup(struct rte_eth_dev *dev, uint16_t
> rx_queue_id,
> uint16_t nb_rx_desc, unsigned int socket_id,
> diff --git a/drivers/net/e1000/em_ethdev.c
> b/drivers/net/e1000/em_ethdev.c
> index 6ebef55588bc..8a752eef52cf 100644
> --- a/drivers/net/e1000/em_ethdev.c
> +++ b/drivers/net/e1000/em_ethdev.c
> @@ -1083,8 +1083,8 @@ eth_em_infos_get(struct rte_eth_dev *dev, struct
> rte_eth_dev_info *dev_info)
> dev_info->max_rx_queues = 1;
> dev_info->max_tx_queues = 1;
>
> - dev_info->rx_queue_offload_capa =
> em_get_rx_queue_offloads_capa(dev);
> - dev_info->rx_offload_capa = em_get_rx_port_offloads_capa(dev) |
> + dev_info->rx_queue_offload_capa =
> em_get_rx_queue_offloads_capa();
> + dev_info->rx_offload_capa = em_get_rx_port_offloads_capa() |
> dev_info->rx_queue_offload_capa;
> dev_info->tx_queue_offload_capa =
> em_get_tx_queue_offloads_capa(dev);
> dev_info->tx_offload_capa = em_get_tx_port_offloads_capa(dev) |
> diff --git a/drivers/net/e1000/em_rxtx.c b/drivers/net/e1000/em_rxtx.c
> index dfd8f2fd0074..e061f80a906a 100644
> --- a/drivers/net/e1000/em_rxtx.c
> +++ b/drivers/net/e1000/em_rxtx.c
> @@ -1359,12 +1359,9 @@ em_reset_rx_queue(struct em_rx_queue *rxq)
> }
>
> uint64_t
> -em_get_rx_port_offloads_capa(struct rte_eth_dev *dev)
> +em_get_rx_port_offloads_capa(void)
> {
> uint64_t rx_offload_capa;
> - uint32_t max_rx_pktlen;
> -
> - max_rx_pktlen = em_get_max_pktlen(dev);
>
> rx_offload_capa =
> DEV_RX_OFFLOAD_VLAN_STRIP |
> @@ -1374,14 +1371,12 @@ em_get_rx_port_offloads_capa(struct
> rte_eth_dev *dev)
> DEV_RX_OFFLOAD_TCP_CKSUM |
> DEV_RX_OFFLOAD_KEEP_CRC |
> DEV_RX_OFFLOAD_SCATTER;
> - if (max_rx_pktlen > RTE_ETHER_MAX_LEN)
> - rx_offload_capa |= DEV_RX_OFFLOAD_JUMBO_FRAME;
>
> return rx_offload_capa;
> }
>
> uint64_t
> -em_get_rx_queue_offloads_capa(struct rte_eth_dev *dev)
> +em_get_rx_queue_offloads_capa(void)
> {
> uint64_t rx_queue_offload_capa;
>
> @@ -1390,7 +1385,7 @@ em_get_rx_queue_offloads_capa(struct
> rte_eth_dev *dev)
> * capability be same to per port queue offloading capability
> * for better convenience.
> */
> - rx_queue_offload_capa = em_get_rx_port_offloads_capa(dev);
> + rx_queue_offload_capa = em_get_rx_port_offloads_capa();
>
> return rx_queue_offload_capa;
> }
> @@ -1839,7 +1834,7 @@ eth_em_rx_init(struct rte_eth_dev *dev)
> * to avoid splitting packets that don't fit into
> * one buffer.
> */
> - if (rxmode->offloads & DEV_RX_OFFLOAD_JUMBO_FRAME
> ||
> + if (dev->data->mtu > RTE_ETHER_MTU ||
> rctl_bsize < RTE_ETHER_MAX_LEN) {
> if (!dev->data->scattered_rx)
> PMD_INIT_LOG(DEBUG, "forcing scatter
> mode");
> @@ -1874,14 +1869,14 @@ eth_em_rx_init(struct rte_eth_dev *dev)
> if ((hw->mac.type == e1000_ich9lan ||
> hw->mac.type == e1000_pch2lan ||
> hw->mac.type == e1000_ich10lan) &&
> - rxmode->offloads &
> DEV_RX_OFFLOAD_JUMBO_FRAME) {
> + dev->data->mtu > RTE_ETHER_MTU) {
> u32 rxdctl = E1000_READ_REG(hw, E1000_RXDCTL(0));
> E1000_WRITE_REG(hw, E1000_RXDCTL(0), rxdctl | 3);
> E1000_WRITE_REG(hw, E1000_ERT, 0x100 | (1 << 13));
> }
>
> if (hw->mac.type == e1000_pch2lan) {
> - if (rxmode->offloads & DEV_RX_OFFLOAD_JUMBO_FRAME)
> + if (dev->data->mtu > RTE_ETHER_MTU)
> e1000_lv_jumbo_workaround_ich8lan(hw, TRUE);
> else
> e1000_lv_jumbo_workaround_ich8lan(hw, FALSE);
> @@ -1908,7 +1903,7 @@ eth_em_rx_init(struct rte_eth_dev *dev)
> /*
> * Configure support of jumbo frames, if any.
> */
> - if (rxmode->offloads & DEV_RX_OFFLOAD_JUMBO_FRAME)
> + if (dev->data->mtu > RTE_ETHER_MTU)
> rctl |= E1000_RCTL_LPE;
> else
> rctl &= ~E1000_RCTL_LPE;
> diff --git a/drivers/net/e1000/igb_rxtx.c b/drivers/net/e1000/igb_rxtx.c
> index de12997b4bdd..9998d4ea4179 100644
> --- a/drivers/net/e1000/igb_rxtx.c
> +++ b/drivers/net/e1000/igb_rxtx.c
> @@ -1640,7 +1640,6 @@ igb_get_rx_port_offloads_capa(struct rte_eth_dev
> *dev)
> DEV_RX_OFFLOAD_IPV4_CKSUM |
> DEV_RX_OFFLOAD_UDP_CKSUM |
> DEV_RX_OFFLOAD_TCP_CKSUM |
> - DEV_RX_OFFLOAD_JUMBO_FRAME |
> DEV_RX_OFFLOAD_KEEP_CRC |
> DEV_RX_OFFLOAD_SCATTER |
> DEV_RX_OFFLOAD_RSS_HASH;
> @@ -2344,7 +2343,7 @@ eth_igb_rx_init(struct rte_eth_dev *dev)
> * Configure support of jumbo frames, if any.
> */
> max_len = dev->data->mtu + E1000_ETH_OVERHEAD;
> - if (dev->data->dev_conf.rxmode.offloads &
> DEV_RX_OFFLOAD_JUMBO_FRAME) {
> + if (dev->data->mtu & RTE_ETHER_MTU) {
> rctl |= E1000_RCTL_LPE;
>
> /*
> diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c
> index e9b718786a39..4322dce260f5 100644
> --- a/drivers/net/ena/ena_ethdev.c
> +++ b/drivers/net/ena/ena_ethdev.c
> @@ -2042,8 +2042,6 @@ static int ena_infos_get(struct rte_eth_dev *dev,
> DEV_RX_OFFLOAD_UDP_CKSUM |
> DEV_RX_OFFLOAD_TCP_CKSUM;
>
> - rx_feat |= DEV_RX_OFFLOAD_JUMBO_FRAME;
> -
> /* Inform framework about available features */
> dev_info->rx_offload_capa = rx_feat;
> dev_info->rx_offload_capa |= DEV_RX_OFFLOAD_RSS_HASH;
> diff --git a/drivers/net/enetc/enetc_ethdev.c
> b/drivers/net/enetc/enetc_ethdev.c
> index a7372c1787c7..6457677d300a 100644
> --- a/drivers/net/enetc/enetc_ethdev.c
> +++ b/drivers/net/enetc/enetc_ethdev.c
> @@ -210,8 +210,7 @@ enetc_dev_infos_get(struct rte_eth_dev *dev
> __rte_unused,
> (DEV_RX_OFFLOAD_IPV4_CKSUM |
> DEV_RX_OFFLOAD_UDP_CKSUM |
> DEV_RX_OFFLOAD_TCP_CKSUM |
> - DEV_RX_OFFLOAD_KEEP_CRC |
> - DEV_RX_OFFLOAD_JUMBO_FRAME);
> + DEV_RX_OFFLOAD_KEEP_CRC);
>
> return 0;
> }
> diff --git a/drivers/net/enic/enic_res.c b/drivers/net/enic/enic_res.c
> index a8f5332a407f..6a4758ea8e8a 100644
> --- a/drivers/net/enic/enic_res.c
> +++ b/drivers/net/enic/enic_res.c
> @@ -209,7 +209,6 @@ int enic_get_vnic_config(struct enic *enic)
> DEV_TX_OFFLOAD_TCP_TSO;
> enic->rx_offload_capa =
> DEV_RX_OFFLOAD_SCATTER |
> - DEV_RX_OFFLOAD_JUMBO_FRAME |
> DEV_RX_OFFLOAD_VLAN_STRIP |
> DEV_RX_OFFLOAD_IPV4_CKSUM |
> DEV_RX_OFFLOAD_UDP_CKSUM |
> diff --git a/drivers/net/failsafe/failsafe_ops.c
> b/drivers/net/failsafe/failsafe_ops.c
> index 5ff33e03e034..47c5efe9ea77 100644
> --- a/drivers/net/failsafe/failsafe_ops.c
> +++ b/drivers/net/failsafe/failsafe_ops.c
> @@ -1193,7 +1193,6 @@ fs_dev_infos_get(struct rte_eth_dev *dev,
> DEV_RX_OFFLOAD_HEADER_SPLIT |
> DEV_RX_OFFLOAD_VLAN_FILTER |
> DEV_RX_OFFLOAD_VLAN_EXTEND |
> - DEV_RX_OFFLOAD_JUMBO_FRAME |
> DEV_RX_OFFLOAD_SCATTER |
> DEV_RX_OFFLOAD_TIMESTAMP |
> DEV_RX_OFFLOAD_SECURITY |
> @@ -1211,7 +1210,6 @@ fs_dev_infos_get(struct rte_eth_dev *dev,
> DEV_RX_OFFLOAD_HEADER_SPLIT |
> DEV_RX_OFFLOAD_VLAN_FILTER |
> DEV_RX_OFFLOAD_VLAN_EXTEND |
> - DEV_RX_OFFLOAD_JUMBO_FRAME |
> DEV_RX_OFFLOAD_SCATTER |
> DEV_RX_OFFLOAD_TIMESTAMP |
> DEV_RX_OFFLOAD_SECURITY |
> diff --git a/drivers/net/fm10k/fm10k_ethdev.c
> b/drivers/net/fm10k/fm10k_ethdev.c
> index 5e4b361ca6c0..093021246286 100644
> --- a/drivers/net/fm10k/fm10k_ethdev.c
> +++ b/drivers/net/fm10k/fm10k_ethdev.c
> @@ -1779,7 +1779,6 @@ static uint64_t
> fm10k_get_rx_port_offloads_capa(struct rte_eth_dev *dev)
> DEV_RX_OFFLOAD_IPV4_CKSUM |
> DEV_RX_OFFLOAD_UDP_CKSUM |
> DEV_RX_OFFLOAD_TCP_CKSUM |
> - DEV_RX_OFFLOAD_JUMBO_FRAME |
> DEV_RX_OFFLOAD_HEADER_SPLIT |
> DEV_RX_OFFLOAD_RSS_HASH);
> }
> diff --git a/drivers/net/hinic/hinic_pmd_ethdev.c
> b/drivers/net/hinic/hinic_pmd_ethdev.c
> index ce0b52c718ab..b1563350ec0e 100644
> --- a/drivers/net/hinic/hinic_pmd_ethdev.c
> +++ b/drivers/net/hinic/hinic_pmd_ethdev.c
> @@ -747,7 +747,6 @@ hinic_dev_infos_get(struct rte_eth_dev *dev, struct
> rte_eth_dev_info *info)
> DEV_RX_OFFLOAD_TCP_CKSUM |
> DEV_RX_OFFLOAD_VLAN_FILTER |
> DEV_RX_OFFLOAD_SCATTER |
> - DEV_RX_OFFLOAD_JUMBO_FRAME |
> DEV_RX_OFFLOAD_TCP_LRO |
> DEV_RX_OFFLOAD_RSS_HASH;
>
> diff --git a/drivers/net/hns3/hns3_ethdev.c
> b/drivers/net/hns3/hns3_ethdev.c
> index 868d381a4772..0c58c55844b0 100644
> --- a/drivers/net/hns3/hns3_ethdev.c
> +++ b/drivers/net/hns3/hns3_ethdev.c
> @@ -2717,7 +2717,6 @@ hns3_dev_infos_get(struct rte_eth_dev *eth_dev,
> struct rte_eth_dev_info *info)
> DEV_RX_OFFLOAD_SCATTER |
> DEV_RX_OFFLOAD_VLAN_STRIP |
> DEV_RX_OFFLOAD_VLAN_FILTER |
> - DEV_RX_OFFLOAD_JUMBO_FRAME |
> DEV_RX_OFFLOAD_RSS_HASH |
> DEV_RX_OFFLOAD_TCP_LRO);
> info->tx_offload_capa = (DEV_TX_OFFLOAD_OUTER_IPV4_CKSUM |
> diff --git a/drivers/net/hns3/hns3_ethdev_vf.c
> b/drivers/net/hns3/hns3_ethdev_vf.c
> index ff28cad53a03..c488e03f23a4 100644
> --- a/drivers/net/hns3/hns3_ethdev_vf.c
> +++ b/drivers/net/hns3/hns3_ethdev_vf.c
> @@ -956,7 +956,6 @@ hns3vf_dev_infos_get(struct rte_eth_dev *eth_dev,
> struct rte_eth_dev_info *info)
> DEV_RX_OFFLOAD_SCATTER |
> DEV_RX_OFFLOAD_VLAN_STRIP |
> DEV_RX_OFFLOAD_VLAN_FILTER |
> - DEV_RX_OFFLOAD_JUMBO_FRAME |
> DEV_RX_OFFLOAD_RSS_HASH |
> DEV_RX_OFFLOAD_TCP_LRO);
> info->tx_offload_capa = (DEV_TX_OFFLOAD_OUTER_IPV4_CKSUM |
> diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
> index dad151eac5f1..ad7802f63031 100644
> --- a/drivers/net/i40e/i40e_ethdev.c
> +++ b/drivers/net/i40e/i40e_ethdev.c
> @@ -3758,7 +3758,6 @@ i40e_dev_info_get(struct rte_eth_dev *dev, struct
> rte_eth_dev_info *dev_info)
> DEV_RX_OFFLOAD_SCATTER |
> DEV_RX_OFFLOAD_VLAN_EXTEND |
> DEV_RX_OFFLOAD_VLAN_FILTER |
> - DEV_RX_OFFLOAD_JUMBO_FRAME |
> DEV_RX_OFFLOAD_RSS_HASH;
>
> dev_info->tx_queue_offload_capa =
> DEV_TX_OFFLOAD_MBUF_FAST_FREE;
> diff --git a/drivers/net/i40e/i40e_ethdev_vf.c
> b/drivers/net/i40e/i40e_ethdev_vf.c
> index f7f9d44ef181..1c314e2ffdd0 100644
> --- a/drivers/net/i40e/i40e_ethdev_vf.c
> +++ b/drivers/net/i40e/i40e_ethdev_vf.c
> @@ -1932,7 +1932,7 @@ i40evf_rxq_init(struct rte_eth_dev *dev, struct
> i40e_rx_queue *rxq)
> /**
> * Check if the jumbo frame and maximum packet length are set
> correctly
> */
> - if (dev_data->dev_conf.rxmode.offloads &
> DEV_RX_OFFLOAD_JUMBO_FRAME) {
> + if (dev_data->mtu > RTE_ETHER_MTU) {
> if (rxq->max_pkt_len <= I40E_ETH_MAX_LEN ||
> rxq->max_pkt_len > I40E_FRAME_SIZE_MAX) {
> PMD_DRV_LOG(ERR, "maximum packet length must
> be "
> @@ -2378,7 +2378,6 @@ i40evf_dev_info_get(struct rte_eth_dev *dev,
> struct rte_eth_dev_info *dev_info)
> DEV_RX_OFFLOAD_TCP_CKSUM |
> DEV_RX_OFFLOAD_OUTER_IPV4_CKSUM |
> DEV_RX_OFFLOAD_SCATTER |
> - DEV_RX_OFFLOAD_JUMBO_FRAME |
> DEV_RX_OFFLOAD_VLAN_FILTER;
>
> dev_info->tx_queue_offload_capa = 0;
> diff --git a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rxtx.c
> index aa43796ef1af..a421acf8f6b6 100644
> --- a/drivers/net/i40e/i40e_rxtx.c
> +++ b/drivers/net/i40e/i40e_rxtx.c
> @@ -2906,7 +2906,7 @@ i40e_rx_queue_config(struct i40e_rx_queue *rxq)
> rxq->max_pkt_len =
> RTE_MIN(hw->func_caps.rx_buf_chain_len * rxq-
> >rx_buf_len,
> data->mtu + I40E_ETH_OVERHEAD);
> - if (data->dev_conf.rxmode.offloads &
> DEV_RX_OFFLOAD_JUMBO_FRAME) {
> + if (data->mtu > RTE_ETHER_MTU) {
> if (rxq->max_pkt_len <= I40E_ETH_MAX_LEN ||
> rxq->max_pkt_len > I40E_FRAME_SIZE_MAX) {
> PMD_DRV_LOG(ERR, "maximum packet length must
> "
> diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c
> index 049671ef3da9..f156add80e0d 100644
> --- a/drivers/net/iavf/iavf_ethdev.c
> +++ b/drivers/net/iavf/iavf_ethdev.c
> @@ -574,7 +574,7 @@ iavf_init_rxq(struct rte_eth_dev *dev, struct
> iavf_rx_queue *rxq)
> /* Check if the jumbo frame and maximum packet length are set
> * correctly.
> */
> - if (dev->data->dev_conf.rxmode.offloads &
> DEV_RX_OFFLOAD_JUMBO_FRAME) {
> + if (dev->data->mtu & RTE_ETHER_MTU) {
> if (max_pkt_len <= IAVF_ETH_MAX_LEN ||
> max_pkt_len > IAVF_FRAME_SIZE_MAX) {
> PMD_DRV_LOG(ERR, "maximum packet length must
> be "
> @@ -939,7 +939,6 @@ iavf_dev_info_get(struct rte_eth_dev *dev, struct
> rte_eth_dev_info *dev_info)
> DEV_RX_OFFLOAD_TCP_CKSUM |
> DEV_RX_OFFLOAD_OUTER_IPV4_CKSUM |
> DEV_RX_OFFLOAD_SCATTER |
> - DEV_RX_OFFLOAD_JUMBO_FRAME |
> DEV_RX_OFFLOAD_VLAN_FILTER |
> DEV_RX_OFFLOAD_RSS_HASH;
>
> diff --git a/drivers/net/ice/ice_dcf_ethdev.c
> b/drivers/net/ice/ice_dcf_ethdev.c
> index 34b6c9b2a7ed..72fdcc29c28a 100644
> --- a/drivers/net/ice/ice_dcf_ethdev.c
> +++ b/drivers/net/ice/ice_dcf_ethdev.c
> @@ -65,7 +65,7 @@ ice_dcf_init_rxq(struct rte_eth_dev *dev, struct
> ice_rx_queue *rxq)
> /* Check if the jumbo frame and maximum packet length are set
> * correctly.
> */
> - if (dev->data->dev_conf.rxmode.offloads &
> DEV_RX_OFFLOAD_JUMBO_FRAME) {
> + if (dev_data->mtu > RTE_ETHER_MTU) {
> if (max_pkt_len <= ICE_ETH_MAX_LEN ||
> max_pkt_len > ICE_FRAME_SIZE_MAX) {
> PMD_DRV_LOG(ERR, "maximum packet length must
> be "
> @@ -664,7 +664,6 @@ ice_dcf_dev_info_get(struct rte_eth_dev *dev,
> DEV_RX_OFFLOAD_TCP_CKSUM |
> DEV_RX_OFFLOAD_OUTER_IPV4_CKSUM |
> DEV_RX_OFFLOAD_SCATTER |
> - DEV_RX_OFFLOAD_JUMBO_FRAME |
> DEV_RX_OFFLOAD_VLAN_FILTER |
> DEV_RX_OFFLOAD_RSS_HASH;
> dev_info->tx_offload_capa =
> diff --git a/drivers/net/ice/ice_dcf_vf_representor.c
> b/drivers/net/ice/ice_dcf_vf_representor.c
> index 970461f3e90a..07843c6dbc92 100644
> --- a/drivers/net/ice/ice_dcf_vf_representor.c
> +++ b/drivers/net/ice/ice_dcf_vf_representor.c
> @@ -141,7 +141,6 @@ ice_dcf_vf_repr_dev_info_get(struct rte_eth_dev
> *dev,
> DEV_RX_OFFLOAD_TCP_CKSUM |
> DEV_RX_OFFLOAD_OUTER_IPV4_CKSUM |
> DEV_RX_OFFLOAD_SCATTER |
> - DEV_RX_OFFLOAD_JUMBO_FRAME |
> DEV_RX_OFFLOAD_VLAN_FILTER |
> DEV_RX_OFFLOAD_VLAN_EXTEND |
> DEV_RX_OFFLOAD_RSS_HASH;
> diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c
> index c1a96d3de183..a17c11e95e0b 100644
> --- a/drivers/net/ice/ice_ethdev.c
> +++ b/drivers/net/ice/ice_ethdev.c
> @@ -3491,7 +3491,6 @@ ice_dev_info_get(struct rte_eth_dev *dev, struct
> rte_eth_dev_info *dev_info)
>
> dev_info->rx_offload_capa =
> DEV_RX_OFFLOAD_VLAN_STRIP |
> - DEV_RX_OFFLOAD_JUMBO_FRAME |
> DEV_RX_OFFLOAD_KEEP_CRC |
> DEV_RX_OFFLOAD_SCATTER |
> DEV_RX_OFFLOAD_VLAN_FILTER;
> diff --git a/drivers/net/ice/ice_rxtx.c b/drivers/net/ice/ice_rxtx.c
> index a3de4172e2bc..a7b0915dabfc 100644
> --- a/drivers/net/ice/ice_rxtx.c
> +++ b/drivers/net/ice/ice_rxtx.c
> @@ -259,7 +259,6 @@ ice_program_hw_rx_queue(struct ice_rx_queue
> *rxq)
> struct ice_rlan_ctx rx_ctx;
> enum ice_status err;
> uint16_t buf_size;
> - struct rte_eth_rxmode *rxmode = &dev_data->dev_conf.rxmode;
> uint32_t rxdid = ICE_RXDID_COMMS_OVS;
> uint32_t regval;
> uint32_t frame_size = dev_data->mtu + ICE_ETH_OVERHEAD;
> @@ -273,7 +272,7 @@ ice_program_hw_rx_queue(struct ice_rx_queue
> *rxq)
> RTE_MIN((uint32_t)ICE_SUPPORT_CHAIN_NUM * rxq-
> >rx_buf_len,
> frame_size);
>
> - if (rxmode->offloads & DEV_RX_OFFLOAD_JUMBO_FRAME) {
> + if (dev_data->mtu > RTE_ETHER_MTU) {
> if (rxq->max_pkt_len <= ICE_ETH_MAX_LEN ||
> rxq->max_pkt_len > ICE_FRAME_SIZE_MAX) {
> PMD_DRV_LOG(ERR, "maximum packet length must
> "
> diff --git a/drivers/net/igc/igc_ethdev.h b/drivers/net/igc/igc_ethdev.h
> index b3473b5b1646..5e6c2ff30157 100644
> --- a/drivers/net/igc/igc_ethdev.h
> +++ b/drivers/net/igc/igc_ethdev.h
> @@ -73,7 +73,6 @@ extern "C" {
> DEV_RX_OFFLOAD_UDP_CKSUM | \
> DEV_RX_OFFLOAD_TCP_CKSUM | \
> DEV_RX_OFFLOAD_SCTP_CKSUM | \
> - DEV_RX_OFFLOAD_JUMBO_FRAME | \
> DEV_RX_OFFLOAD_KEEP_CRC | \
> DEV_RX_OFFLOAD_SCATTER | \
> DEV_RX_OFFLOAD_RSS_HASH)
> diff --git a/drivers/net/igc/igc_txrx.c b/drivers/net/igc/igc_txrx.c
> index d80808a002f5..30940857eac0 100644
> --- a/drivers/net/igc/igc_txrx.c
> +++ b/drivers/net/igc/igc_txrx.c
> @@ -1099,7 +1099,7 @@ igc_rx_init(struct rte_eth_dev *dev)
> IGC_WRITE_REG(hw, IGC_RCTL, rctl & ~IGC_RCTL_EN);
>
> /* Configure support of jumbo frames, if any. */
> - if (offloads & DEV_RX_OFFLOAD_JUMBO_FRAME)
> + if (dev->data->mtu & RTE_ETHER_MTU)
> rctl |= IGC_RCTL_LPE;
> else
> rctl &= ~IGC_RCTL_LPE;
> diff --git a/drivers/net/ionic/ionic_ethdev.c
> b/drivers/net/ionic/ionic_ethdev.c
> index 97447a10e46a..795980cb1ca5 100644
> --- a/drivers/net/ionic/ionic_ethdev.c
> +++ b/drivers/net/ionic/ionic_ethdev.c
> @@ -414,7 +414,6 @@ ionic_dev_info_get(struct rte_eth_dev *eth_dev,
> DEV_RX_OFFLOAD_IPV4_CKSUM |
> DEV_RX_OFFLOAD_UDP_CKSUM |
> DEV_RX_OFFLOAD_TCP_CKSUM |
> - DEV_RX_OFFLOAD_JUMBO_FRAME |
> DEV_RX_OFFLOAD_VLAN_FILTER |
> DEV_RX_OFFLOAD_VLAN_STRIP |
> DEV_RX_OFFLOAD_SCATTER |
> diff --git a/drivers/net/ipn3ke/ipn3ke_representor.c
> b/drivers/net/ipn3ke/ipn3ke_representor.c
> index 377b96c0236a..4e5d234e8c7d 100644
> --- a/drivers/net/ipn3ke/ipn3ke_representor.c
> +++ b/drivers/net/ipn3ke/ipn3ke_representor.c
> @@ -74,8 +74,7 @@ ipn3ke_rpst_dev_infos_get(struct rte_eth_dev
> *ethdev,
> DEV_RX_OFFLOAD_TCP_CKSUM |
> DEV_RX_OFFLOAD_OUTER_IPV4_CKSUM |
> DEV_RX_OFFLOAD_VLAN_EXTEND |
> - DEV_RX_OFFLOAD_VLAN_FILTER |
> - DEV_RX_OFFLOAD_JUMBO_FRAME;
> + DEV_RX_OFFLOAD_VLAN_FILTER;
>
> dev_info->tx_queue_offload_capa =
> DEV_TX_OFFLOAD_MBUF_FAST_FREE;
> dev_info->tx_offload_capa =
Reviewed-by: Rosen Xu <rosen.xu at intel.com>
More information about the dev
mailing list