[dpdk-dev] [PATCH 2/2] eal: handle compressed firmwares

[David Marchand]

On Thu, Jun 3, 2021 at 9:23 AM David Marchand <david.marchand at redhat.com> wrote:
> > > diff --git a/config/meson.build b/config/meson.build
> > > index 017bb2efbb..337daa2719 100644
> > > --- a/config/meson.build
> > > +++ b/config/meson.build
> > > @@ -166,6 +166,15 @@ if fdt_dep.found() and cc.has_header('fdt.h')
> > >      dpdk_extra_ldflags += '-lfdt'
> > >  endif
> > >
> > > +has_libarchive = 0
> > > +archive_dep = cc.find_library('libarchive', required: false)
> > > +if archive_dep.found() and cc.has_header('archive.h')
> > > +    dpdk_conf.set10('RTE_HAS_LIBARCHIVE', true)
> > > +    has_libarchive = 1
> > > +    add_project_link_arguments('-larchive', language: 'c')
> > > +    dpdk_extra_ldflags += '-larchive'
> > > +endif
> > > +
> >
> > Why not use pkg-config?
> > `has_libarchive` is unused.
>
> Frankly, I just copied the logic already present in config/meson.build.
> If there is better to do, please advise.

Ah ok, I think I understand.
Do you mean to align on libbsd?


-- 
David Marchand