[dpdk-dev] [PATCH 04/28] common/cnxk: add support for changing internal loopback

[Jerin Jacob]

On Tue, Jun 1, 2021 at 3:12 AM Tomasz Duszynski <tduszynski at marvell.com> wrote:
>
> Add support for enabling or disabling internal loopback.
>
> Signed-off-by: Tomasz Duszynski <tduszynski at marvell.com>
> Signed-off-by: Jakub Palider <jpalider at marvell.com>


In all the git commit message we can shorten

From:
common/cnxk: add support for changing internal loopback

To:
common/cnxk: support for changing internal loopback

> ---
>  drivers/common/cnxk/roc_bphy_cgx.c      | 30 +++++++++++++++++++++++++
>  drivers/common/cnxk/roc_bphy_cgx.h      |  4 ++++
>  drivers/common/cnxk/roc_bphy_cgx_priv.h |  4 ++++
>  drivers/common/cnxk/version.map         |  2 ++
>  4 files changed, 40 insertions(+)
>
> diff --git a/drivers/common/cnxk/roc_bphy_cgx.c b/drivers/common/cnxk/roc_bphy_cgx.c
> index c7ba53ede..45088d5d4 100644
> --- a/drivers/common/cnxk/roc_bphy_cgx.c
> +++ b/drivers/common/cnxk/roc_bphy_cgx.c
> @@ -213,6 +213,24 @@ roc_bphy_cgx_lmac_exists(struct roc_bphy_cgx *roc_cgx, unsigned int lmac)
>                (roc_cgx->lmac_bmap & BIT_ULL(lmac));
>  }
>
> +static int
> +roc_bphy_cgx_intlbk_ena_dis(struct roc_bphy_cgx *roc_cgx, unsigned int lmac,
> +                           bool enable)
> +{
> +       uint64_t scr1, scr0;
> +
> +       if (!roc_cgx)
> +               return -EINVAL;
> +
> +       if (!roc_bphy_cgx_lmac_exists(roc_cgx, lmac))
> +               return -EINVAL;

-ENODEV?

> +
> +       scr1 = FIELD_PREP(SCR1_ETH_CMD_ID, ETH_CMD_INTERNAL_LBK) |
> +              FIELD_PREP(SCR1_ETH_CTL_ARGS_ENABLE, enable);
> +
> +       return roc_bphy_cgx_intf_req(roc_cgx, lmac, scr1, &scr0);
> +}
> +
>  int
>  roc_bphy_cgx_get_linkinfo(struct roc_bphy_cgx *roc_cgx, unsigned int lmac,
>                           struct roc_bphy_cgx_link_info *info)
> @@ -243,3 +261,15 @@ roc_bphy_cgx_get_linkinfo(struct roc_bphy_cgx *roc_cgx, unsigned int lmac,
>
>         return 0;
>  }

>