[dpdk-dev] [RFC PATCH v3 1/3] sched: add PIE based congestion management

Stephen Hemminger stephen at networkplumber.org
Mon Jun 21 20:17:59 CEST 2021


On Mon, 21 Jun 2021 08:35:04 +0100
"Liguzinski, WojciechX" <wojciechx.liguzinski at intel.com> wrote:

> +/**
> + * @brief Initialises run-time data
> + *
> + * @param pie [in,out] data pointer to PIE runtime data
> + *
> + * @return Operation status
> + * @retval 0 success
> + * @retval !0 error
> + */
> +int
> +rte_pie_rt_data_init(struct rte_pie *pie);

All the new code needs to be marked experimental.
Why return an error on the init() function, then you are going to
make application check the result and lead to lots more code.

Other places in DPDK use void for init functions.


More information about the dev mailing list