[dpdk-dev] [PATCH] ethdev: fix doc comment for struct rte_flow_action
Singh, Aman Deep
aman.deep.singh at intel.com
Fri Jun 25 08:58:51 CEST 2021
On 6/23/2021 7:43 PM, Andrew Rybchenko wrote:
> On 6/23/21 4:39 PM, Ori Kam wrote:
>> Hi Jan,
>>
>>> -----Original Message-----
>>> From: Jan Viktorin <viktorin at cesnet.cz>
>>> Sent: Wednesday, June 23, 2021 12:18 PM
>>>
>>> The struct rte_flow_action was missing from DPDK API documentation.
>>>
>>> Signed-off-by: Jan Viktorin <viktorin at cesnet.cz>
>>> ---
>>> lib/ethdev/rte_flow.h | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/lib/ethdev/rte_flow.h b/lib/ethdev/rte_flow.h index
>>> 961a5884fe..70f455d47d 100644
>>> --- a/lib/ethdev/rte_flow.h
>>> +++ b/lib/ethdev/rte_flow.h
>>> @@ -3278,7 +3278,7 @@ rte_flow_dynf_metadata_set(struct rte_mbuf *m,
>>> uint32_t v)
>>> *RTE_FLOW_DYNF_METADATA(m) = v;
>>> }
>>>
>>> -/*
>>> +/**
>>> * Definition of a single action.
>>> *
>>> * A list of actions is terminated by a END action.
>>> --
>>> 2.32.0
>> Acked-by: Ori Kam <orika at nvidia.com>
>> Thanks,
>> Ori
>>
> Not that important, but it looks like a fix which should be
> backported to stable branches as well.
> Shouldn't "Fixes:" be added with Cc to stable?
>
> Andrew.
Acked-by: Aman Deep Singh <aman.deep.singh at intel.com>
Thanks,
Aman
More information about the dev
mailing list