[dpdk-dev] [PATCH v14 1/9] lib: build libraries that testpmd depends on

[Tyler Retzlaff]

On Mon, Jun 28, 2021 at 01:35:09PM +0300, Andrew Rybchenko wrote:
> On 6/28/21 1:01 PM, Andrew Rybchenko wrote:
> >On 6/24/21 1:34 AM, Jie Zhou wrote:
> >>Enable building libraries that testpmd depends on for Windows
> >>
> >>Signed-off-by: Jie Zhou <jizh at microsoft.com>
> >>Signed-off-by: Jie Zhou <jizh at linux.microsoft.com>
> >
> >Why are two a bit difference Signed-off-by used in these
> >patches? Can we drop the first one and keep the second one
> >which matches E-mail From?
> 
> In fact looking at git log I see both E-mail addresses
> present, but it looks like the first one (w/o linux.) is
> used more often.

yes, the CI system rejects the patch without the first because it
doesn't match the original commit. it also rejects without the second
because it needs to match the dev email list subscriber mail so both
have been provided to pass CI.

i think future patches submitted won't be an issue because git local
config for the dpdk clone has been changed to match the second which is
also the subscription mail but changing the config doesn't re-write
the history on the commits (and it shouldn't).