[dpdk-dev] [RFC v2] porting AddressSanitizer feature to DPDK

[Lin, Xueqin]

> -----Original Message-----
> From: Burakov, Anatoly <anatoly.burakov at intel.com>
> Sent: Monday, June 28, 2021 10:22 PM
> To: David Marchand <david.marchand at redhat.com>; Lin, Xueqin
> <xueqin.lin at intel.com>
> Cc: Jerin Jacob <jerinjacobk at gmail.com>; Peng, ZhihongX
> <zhihongx.peng at intel.com>; Ananyev, Konstantin
> <konstantin.ananyev at intel.com>; Stephen Hemminger
> <stephen at networkplumber.org>; dpdk-dev <dev at dpdk.org>
> Subject: Re: [dpdk-dev] [RFC v2] porting AddressSanitizer feature to DPDK
> 
> On 18-Jun-21 10:04 AM, David Marchand wrote:
> > On Fri, Jun 18, 2021 at 9:49 AM Lin, Xueqin <xueqin.lin at intel.com> wrote:
> >>>> Suggest listing demo code and tool capture information for user to
> >>>> try if
> >>> tool works, also add this part into doc.
> >>>>
> >>>>>
> >>>>> # Also, Please update the release note for this feature.
> >>>> Sure, we can update the release note if code merge.
> >>>
> >>> Probably you can send v1 version next i.e change the RFC status to
> >>> get merged.
> >>
> >> Sure, we will send v1 patch if no obvious objection for that, hope patch
> could receive some ACKs and could success to merge, thanks.
> >
> > How did you test this work?
> >
> > UNH recently started testing with ASAN and it reveals leaks just in
> > the unit test.
> >
> > Merging these annotations will help catch more issues.
> > But users will hit the current issues that we must fix first.
> >
> 
> As far as i can tell, the regular build is not affected by this patch, so no issues
> will be hit until someone actually runs the test. IMO it's better to merge it
> early to catch more issues than to gate the feature on the condition that we
> fix all bugs unrelated to this feature first.

Thanks for review and good feedback. 
> 
> --
> Thanks,
> Anatoly