[dpdk-dev] [PATCH v2 4/9] net/hns3: adjust the format of RAS related structures

Ferruh Yigit ferruh.yigit at intel.com
Thu Mar 11 19:25:43 CET 2021


On 3/10/2021 6:16 AM, Min Hu (Connor) wrote:
> From: Hongbo Zheng <zhenghongbo3 at huawei.com>
> 
> Adjust the format of hns3 RAS related structures to resolve
> the static check warnings of reviewbot_c.This patch has no
> impact on function.
> 
> The correspond warnings of reviewbot_c:
> When struct and union members are initialized, each member
> is initialized on a separate line.
> 
> Signed-off-by: Hongbo Zheng <zhenghongbo3 at huawei.com>
> Signed-off-by: Min Hu (Connor) <humin29 at huawei.com>

<...>

>   static const struct hns3_hw_error ppu_mpf_abnormal_int_st1[] = {
> -	{ .int_msk = 0xFFFFFFFF,
> -	  .msg = "rpu_rx_pkt_ecc_mbit_err",
> -	  .reset_level = HNS3_GLOBAL_RESET },
> -	{ .int_msk = 0,
> -	  .msg = NULL,
> -	  .reset_level = HNS3_NONE_RESET}
> +	{
> +		.int_msk = 0xFFFFFFFF,
> +		.msg = "rpu_rx_pkt_ecc_mbit_err",
> +		.reset_level = HNS3_GLOBAL_RESET
> +	}, {
> +		.int_msk = 0,
> +		.msg = NULL,
> +		.reset_level = HNS3_NONE_RESET
> +	}
>   };

Hi Connor,

This looks like just a syntax change, I wonder what is mentioned
'reviewbot_c' that generates a warning?



More information about the dev mailing list