[dpdk-dev] [PATCH] doc: update sample actions support in mlx5 guide

[Jiawei(Jonny) Wang]

Hi Thomas,

> -----Original Message-----
> From: Thomas Monjalon <thomas at monjalon.net>
> Sent: Tuesday, March 9, 2021 9:39 PM
> To: Jiawei(Jonny) Wang <jiaweiw at nvidia.com>
> Cc: Slava Ovsiienko <viacheslavo at nvidia.com>; Matan Azrad
> <matan at nvidia.com>; Ori Kam <orika at nvidia.com>; dev at dpdk.org; Raslan
> Darawsheh <rasland at nvidia.com>
> Subject: Re: [PATCH] doc: update sample actions support in mlx5 guide
> 
> 09/03/2021 14:09, Jiawei Wang:
> > +  - Supports ``MARK``, ``COUNT``, ``QUEUE``, ``RSS`` as sample actions for
> NIC Rx sampling/mirroring flow.
> 
> "sample actions for NIC Rx sampling" is redundant.
> I suggest "Supports [...] actions for NIC Rx flow sampling/mirroring."
> 

These actions are support in the sample action list, user also can add modify, decap , encap in the NIC RX flow;
How about this:

"For NIC RX flow with sample action, Supports [...] actions in the sample action list" ? 

> > +  - Supports ``RAW ENCAP``, ``Port ID`` as sample actions for E-Switch
> mirroring (sample ratio = 1) flow.
> 
> I suggest "Supports [...] actions for E-Switch flow mirroring."
> 
> If lines are long, do not hesitate to start a new line after a punctuation.
> 

Ok, I will split into two lines.

Thanks.