[dpdk-dev] [EXTERNAL] [PATCH] WindowsGSGDoc: Update the meson version to use for Windows DPDK

[Thomas Monjalon]

08/03/2021 19:32, Jie Zhou:
> Add Dmitry.

There are more maintainers to Cc.
I recommend using Linux for sending the patches,
so you can use the script devtools/get-maintainer.sh
with the option --cc-cmd.


> From: Jie Zhou <jizh at microsoft.com>
> 
> Meson with Windows clang generates incorrect linker flag "--subsystem,console" instead of "/subsystem:console" which will fail the DPDK build. This is discovered at porting testpmd.
> 
> Meson 0.57.0 has the fix and should be used for DPDK Windows build.
> Update the DPDK WindowsGSG DPDK Build document for the proper meson version. Will then sync with ci at dpdk.org to update meson in CI pipeline.
> 
> Signed-off-by: Jie Zhou <jizh at linux.microsoft.com>

Why signing with a different email address than the "From"?

[...]
>  	https://nam06.safelinks.protection.outlook.com/?url=http%3A%2F%2Fmesonbuild.com%2FGetting-meson.html%23installing-meson-and-ninja-with-the-msi-installer%2522&data=04%7C01%7Cjizh%40microsoft.com%7C124559f34a4245cef68808d8d91d1508%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637498066227214579%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=oXVIHUzLnN0KkaRED1skiCq3W1LQRJS8H0NAHCCvu6A%3D&reserved=0

That's interesting how your mail server can break a patch :)


> -Recommended version is either Meson 0.47.1 (baseline) or the latest release.
> +Recommended version is either Meson 0.57.0 (baseline) or the latest release.

I am OK with the change. What others think?