[dpdk-dev] [PATCH v4 10/20] net/bnxt: remove devargs for stats accumulation

Ajit Khaparde ajit.khaparde at broadcom.com
Wed Nov 3 14:35:45 CET 2021


On Wed, Nov 3, 2021 at 6:24 AM Ferruh Yigit <ferruh.yigit at intel.com> wrote:
>
> On 11/3/2021 12:52 AM, Ajit Khaparde wrote:
> > From: Kishore Padmanabha <kishore.padmanabha at broadcom.com>
> >
> > The accumulation of flow counters is not determined by the
> > application device arguments anymore. Instead it is now dictated by
> > the platform capabilities whether to do software based accumulation or not.
> >
> > Signed-off-by: Kishore Padmanabha <kishore.padmanabha at broadcom.com>
> > Signed-off-by: Venkat Duvvuru <venkatkumar.duvvuru at broadcom.com>
> > Reviewed-by: Mike Baucom <michael.baucom at broadcom.com>
> > Reviewed-by: Ajit Khaparde <ajit.khaparde at broadcom.com>
>
> <...>
>
> > @@ -87,7 +87,6 @@ static const struct rte_pci_id bnxt_pci_id_map[] = {
> >       { .vendor_id = 0, /* sentinel */ },
> >   };
> >
> > -#define      BNXT_DEVARG_ACCUM_STATS "accum-stats"
> >   #define BNXT_DEVARG_FLOW_XSTAT      "flow-xstat"
> >   #define BNXT_DEVARG_MAX_NUM_KFLOWS  "max-num-kflows"
> >   #define BNXT_DEVARG_REPRESENTOR     "representor"
>
> Hi Ajit,
>
> Not for this patch, but I recognized that runtime devargs for the driver
> is not documented at all.
>
> Can you please have a separate patch to document them in bnxt.rst?
Hi Freeuh,
Yes. I am working on that.


More information about the dev mailing list