[dpdk-dev] [PATCH 2/2] buildtools: enable chkincs on Windows

Dmitry Kozlyuk dmitry.kozliuk at gmail.com
Fri Oct 1 18:37:26 CEST 2021


Independent header compilation test (chkincs) was disabled on Windows.
The comment stated that the shebang line in the generator script was not
working. Meson 0.57.0, currently recommended for Windows, successfully
parses that line and invokes the script. Remove the OS restriction
as its reason no longer applies.

Fixes: 05050ac4ce99 ("build: add header includes check")
Cc: bruce.richardson at intel.com

Signed-off-by: Dmitry Kozlyuk <dmitry.kozliuk at gmail.com>
---
 buildtools/chkincs/meson.build | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/buildtools/chkincs/meson.build b/buildtools/chkincs/meson.build
index 34dcd81ce1..5ffca89761 100644
--- a/buildtools/chkincs/meson.build
+++ b/buildtools/chkincs/meson.build
@@ -6,11 +6,6 @@ if not get_option('check_includes')
     subdir_done()
 endif
 
-if is_windows
-    # for windows, the shebang line in the script won't work.
-    error('option "check_includes" is not supported on windows')
-endif
-
 gen_c_file_for_header = find_program('gen_c_file_for_header.py')
 gen_c_files = generator(gen_c_file_for_header,
         output: '@BASENAME at .c',
-- 
2.29.3



More information about the dev mailing list