[dpdk-dev] [PATCH v3] telemetry: fix "in-memory" process socket conflicts

Ferruh Yigit ferruh.yigit at intel.com
Tue Oct 5 13:47:25 CEST 2021


On 9/29/2021 2:54 PM, Bruce Richardson wrote:
> When DPDK is run with --in-memory mode, multiple processes can run
> simultaneously using the same runtime dir. This leads to each process,
> as it starts up, removing the telemetry socket of another process,
> giving unexpected behaviour.
> 
> This patch changes that behaviour to first check if the existing socket
> is active. If not, it's an old socket to be cleaned up and can be
> removed. If it is active, telemetry initialization fails and an error
> message is printed out giving instructions on how to remove the error;
> either by using file-prefix to have a different runtime dir (and
> therefore socket path) or by disabling telemetry if it not needed.
> 
> Fixes: 6dd571fd07c3 ("telemetry: introduce new functionality")
> 
> Reported-by: David Marchand <david.marchand at redhat.com>
> Signed-off-by: Bruce Richardson <bruce.richardson at intel.com>
> Acked-by: Ciara Power <ciara.power at intel.com>

Off the topic.

This is the patch 100.000 in patchwork! Wow, that is huge.

This may be something to celebrate on next face to face meeting.
And I assume Bruce will be buying as the owner of the patch 100000 :)

https://patches.dpdk.org/api/1.2/patches/100000/

The historical numbers from DPDK patchwork:
100000 - Sept. 29, 2021 (184 days) [ 6 months / 26 weeks and 2 days ]
  90000 - March 29, 2021 (172 days)
  80000 - Oct.   8, 2020 (153 days)
  70000 - May    8, 2020 (224 days)
  60000 - Sept. 27, 2019 (248 days)
  50000 - Jan.  22, 2019 (253 days)
  40000 - May   14, 2018 (217 days)
  30000 - Oct.   9, 2017 (258 days)
  20000 - Jan.  25, 2017 (372 days)
  10000 - Jan.  20, 2016 (645 days)
  00001 - April 16, 2014

Last two years average is 10K patch in ~185 days, that is more patch per day
comparing to previous years.
Not sure if this is Covid-19 effect or simply DPDK is getting more popular.

Thanks again to all contributors.



More information about the dev mailing list