[dpdk-dev] [PATCH] net/softnic: remove useless address check

[Singh, Jasvinder]

> -----Original Message-----
> From: Yigit, Ferruh <ferruh.yigit at intel.com>
> Sent: Monday, October 4, 2021 6:27 PM
> To: Singh, Jasvinder <jasvinder.singh at intel.com>; Dumitrescu, Cristian
> <cristian.dumitrescu at intel.com>
> Cc: Yigit, Ferruh <ferruh.yigit at intel.com>; dev at dpdk.org
> Subject: [PATCH] net/softnic: remove useless address check
> 
> Reported by "gcc (GCC) 12.0.0 20211003 (experimental)":
> 
> ./drivers/net/softnic/rte_eth_softnic_cli.c:
> 	In function ‘tmgr_hierarchy_default’:
> ./drivers/net/softnic/rte_eth_softnic_cli.c:634:73:
> 	error: the comparison will always evaluate as ‘true’ for the
> 	address of ‘tc_valid’ will never be NULL [-Werror=address]
>   634 | (&params->shared_shaper_id.tc_valid[0]) ? 1 : 0,
>       |                                         ^
> 
> Fixing it by removing useless check.
> 
> Signed-off-by: Ferruh Yigit <ferruh.yigit at intel.com>
> ---
> Intention of the check is not clear, sending the basic fix to trigger the
> discussion for proper fix.
> ---
>  drivers/net/softnic/rte_eth_softnic_cli.c | 26 +++++++++++------------
>  1 file changed, 13 insertions(+), 13 deletions(-)
> 
> diff --git a/drivers/net/softnic/rte_eth_softnic_cli.c
> b/drivers/net/softnic/rte_eth_softnic_cli.c
> index 932ec15f49b0..b04e78c6e0af 100644
> --- a/drivers/net/softnic/rte_eth_softnic_cli.c
> +++ b/drivers/net/softnic/rte_eth_softnic_cli.c
> @@ -631,7 +631,7 @@ tmgr_hierarchy_default(struct pmd_internals
> *softnic,
>  			.shaper_profile_id = params-
> >shaper_profile_id.tc[0],
>  			.shared_shaper_id = &shared_shaper_id[0],
>  			.n_shared_shapers =
> -				(&params->shared_shaper_id.tc_valid[0]) ? 1
> : 0,
> +				(params->shared_shaper_id.tc_valid[0]) ? 1 :
> 0,
>  			.nonleaf = {
>  				.n_sp_priorities = 1,
>  			},
> @@ -641,7 +641,7 @@ tmgr_hierarchy_default(struct pmd_internals
> *softnic,
>  			.shaper_profile_id = params-
> >shaper_profile_id.tc[1],
>  			.shared_shaper_id = &shared_shaper_id[1],
>  			.n_shared_shapers =
> -				(&params->shared_shaper_id.tc_valid[1]) ? 1
> : 0,
> +				(params->shared_shaper_id.tc_valid[1]) ? 1 :
> 0,
>  			.nonleaf = {
>  				.n_sp_priorities = 1,
>  			},
> @@ -651,7 +651,7 @@ tmgr_hierarchy_default(struct pmd_internals
> *softnic,
>  			.shaper_profile_id = params-
> >shaper_profile_id.tc[2],
>  			.shared_shaper_id = &shared_shaper_id[2],
>  			.n_shared_shapers =
> -				(&params->shared_shaper_id.tc_valid[2]) ? 1
> : 0,
> +				(params->shared_shaper_id.tc_valid[2]) ? 1 :
> 0,
>  			.nonleaf = {
>  				.n_sp_priorities = 1,
>  			},
> @@ -661,7 +661,7 @@ tmgr_hierarchy_default(struct pmd_internals
> *softnic,
>  			.shaper_profile_id = params-
> >shaper_profile_id.tc[3],
>  			.shared_shaper_id = &shared_shaper_id[3],
>  			.n_shared_shapers =
> -				(&params->shared_shaper_id.tc_valid[3]) ? 1
> : 0,
> +				(params->shared_shaper_id.tc_valid[3]) ? 1 :
> 0,
>  			.nonleaf = {
>  				.n_sp_priorities = 1,
>  			},
> @@ -671,7 +671,7 @@ tmgr_hierarchy_default(struct pmd_internals
> *softnic,
>  			.shaper_profile_id = params-
> >shaper_profile_id.tc[4],
>  			.shared_shaper_id = &shared_shaper_id[4],
>  			.n_shared_shapers =
> -				(&params->shared_shaper_id.tc_valid[4]) ? 1
> : 0,
> +				(params->shared_shaper_id.tc_valid[4]) ? 1 :
> 0,
>  			.nonleaf = {
>  				.n_sp_priorities = 1,
>  			},
> @@ -681,7 +681,7 @@ tmgr_hierarchy_default(struct pmd_internals
> *softnic,
>  			.shaper_profile_id = params-
> >shaper_profile_id.tc[5],
>  			.shared_shaper_id = &shared_shaper_id[5],
>  			.n_shared_shapers =
> -				(&params->shared_shaper_id.tc_valid[5]) ? 1
> : 0,
> +				(params->shared_shaper_id.tc_valid[5]) ? 1 :
> 0,
>  			.nonleaf = {
>  				.n_sp_priorities = 1,
>  			},
> @@ -691,7 +691,7 @@ tmgr_hierarchy_default(struct pmd_internals
> *softnic,
>  			.shaper_profile_id = params-
> >shaper_profile_id.tc[6],
>  			.shared_shaper_id = &shared_shaper_id[6],
>  			.n_shared_shapers =
> -				(&params->shared_shaper_id.tc_valid[6]) ? 1
> : 0,
> +				(params->shared_shaper_id.tc_valid[6]) ? 1 :
> 0,
>  			.nonleaf = {
>  				.n_sp_priorities = 1,
>  			},
> @@ -701,7 +701,7 @@ tmgr_hierarchy_default(struct pmd_internals
> *softnic,
>  			.shaper_profile_id = params-
> >shaper_profile_id.tc[7],
>  			.shared_shaper_id = &shared_shaper_id[7],
>  			.n_shared_shapers =
> -				(&params->shared_shaper_id.tc_valid[7]) ? 1
> : 0,
> +				(params->shared_shaper_id.tc_valid[7]) ? 1 :
> 0,
>  			.nonleaf = {
>  				.n_sp_priorities = 1,
>  			},
> @@ -711,7 +711,7 @@ tmgr_hierarchy_default(struct pmd_internals
> *softnic,
>  			.shaper_profile_id = params-
> >shaper_profile_id.tc[8],
>  			.shared_shaper_id = &shared_shaper_id[8],
>  			.n_shared_shapers =
> -				(&params->shared_shaper_id.tc_valid[8]) ? 1
> : 0,
> +				(params->shared_shaper_id.tc_valid[8]) ? 1 :
> 0,
>  			.nonleaf = {
>  				.n_sp_priorities = 1,
>  			},
> @@ -721,7 +721,7 @@ tmgr_hierarchy_default(struct pmd_internals
> *softnic,
>  			.shaper_profile_id = params-
> >shaper_profile_id.tc[9],
>  			.shared_shaper_id = &shared_shaper_id[9],
>  			.n_shared_shapers =
> -				(&params->shared_shaper_id.tc_valid[9]) ? 1
> : 0,
> +				(params->shared_shaper_id.tc_valid[9]) ? 1 :
> 0,
>  			.nonleaf = {
>  				.n_sp_priorities = 1,
>  			},
> @@ -731,7 +731,7 @@ tmgr_hierarchy_default(struct pmd_internals
> *softnic,
>  			.shaper_profile_id = params-
> >shaper_profile_id.tc[10],
>  			.shared_shaper_id = &shared_shaper_id[10],
>  			.n_shared_shapers =
> -				(&params->shared_shaper_id.tc_valid[10]) ?
> 1 : 0,
> +				(params->shared_shaper_id.tc_valid[10]) ? 1
> : 0,
>  			.nonleaf = {
>  				.n_sp_priorities = 1,
>  			},
> @@ -741,7 +741,7 @@ tmgr_hierarchy_default(struct pmd_internals
> *softnic,
>  			.shaper_profile_id = params-
> >shaper_profile_id.tc[11],
>  			.shared_shaper_id = &shared_shaper_id[11],
>  			.n_shared_shapers =
> -				(&params->shared_shaper_id.tc_valid[11]) ?
> 1 : 0,
> +				(params->shared_shaper_id.tc_valid[11]) ? 1
> : 0,
>  			.nonleaf = {
>  				.n_sp_priorities = 1,
>  			},
> @@ -751,7 +751,7 @@ tmgr_hierarchy_default(struct pmd_internals
> *softnic,
>  			.shaper_profile_id = params-
> >shaper_profile_id.tc[12],
>  			.shared_shaper_id = &shared_shaper_id[12],
>  			.n_shared_shapers =
> -				(&params->shared_shaper_id.tc_valid[12]) ?
> 1 : 0,
> +				(params->shared_shaper_id.tc_valid[12]) ? 1
> : 0,
>  			.nonleaf = {
>  				.n_sp_priorities = 1,
>  			},
> --
> 2.31.1


Thanks, Ferruh.

Ached-by: Jasvinder Singh <jasvinder.singh at intel.com>