[dpdk-dev] [PATCH v2 1/3] dmadev: hide devices array

[fengchengwen]

On 2021/10/26 14:04, Radha Mohan wrote:
> On Thu, Oct 21, 2021 at 7:04 AM Kevin Laatz <kevin.laatz at intel.com> wrote:
>>
>> On 21/10/2021 13:59, Chengwen Feng wrote:
>>> From: David Marchand <david.marchand at redhat.com>
>>>
>>> No need to expose rte_dma_devices out of the dmadev library.
>>> Existing helpers should be enough, and inlines make use of
>>> rte_dma_fp_objs.
> 
> I asked this earlier and was asked to use rte_dma_devices[] array by Kevin.
> Now that it has been made static is there a different way to get the
> fp_obj->private_data from a PMD .remove function ?
> I need the private data for DMA queue state cleanup.

PMD .remove function just call rte_dma_pmd_release() and it's will
invoke PMD .dev_close ops:
  rte_dma_pmd_release()
    --> rte_dma_close()
      --> PMD .dev_close ops

PMD could implemente cleanup in dev_close ops.

If the PMD want support multi-process, just make sure only the primary
could do really cleanup in the dev_close ops.

> 
>>>
>>> Signed-off-by: David Marchand <david.marchand at redhat.com>
>>> Reviewed-by: Chengwen Feng <fengchengwen at huawei.com>
>>> Tested-by: Conor Walsh <conor.walsh at intel.com>
>>> ---
>>>   app/test/test_dmadev.c      | 5 +++--
>>>   lib/dmadev/rte_dmadev.c     | 2 +-
>>>   lib/dmadev/rte_dmadev_pmd.h | 2 --
>>>   lib/dmadev/version.map      | 1 -
>>>   4 files changed, 4 insertions(+), 6 deletions(-)
>>>
>>
>> Acked-by: Kevin Laatz <kevin.laatz at intel.com>
> 
> .
>