[dpdk-dev] [PATCH] checkpatches: suppress warning about strlcpy

Bruce Richardson bruce.richardson at intel.com
Mon Sep 13 10:08:49 CEST 2021


On Fri, Sep 10, 2021 at 10:54:43AM -0700, Stephen Hemminger wrote:
> Latest versions of Linux kernel checkpatch now complain about
> uses of strlcpy (kernel perfers strcspy).
> 
> WARNING:STRLCPY: Prefer strscpy over strlcpy
> 
> But DPDK does not have strcspy so suppress the warning.
                           ^^^
typo :-)
> 
> Signed-off-by: Stephen Hemminger <stephen at networkplumber.org>

We actually do have an rte_strscpy function, but on the other hand I
believe that strlcpy should very much also be acceptable.

Acked-by: Bruce Richardson <bruce.richardson at intel.com>
> ---
>  devtools/checkpatches.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh
> index c314d83a29d3..057208c8e1ea 100755
> --- a/devtools/checkpatches.sh
> +++ b/devtools/checkpatches.sh
> @@ -33,7 +33,7 @@ VOLATILE,PREFER_PACKED,PREFER_ALIGNED,PREFER_PRINTF,\
>  PREFER_KERNEL_TYPES,PREFER_FALLTHROUGH,BIT_MACRO,CONST_STRUCT,\
>  SPLIT_STRING,LONG_LINE_STRING,C99_COMMENT_TOLERANCE,\
>  LINE_SPACING,PARENTHESIS_ALIGNMENT,NETWORKING_BLOCK_COMMENT_STYLE,\
> -NEW_TYPEDEFS,COMPARISON_TO_NULL"
> +NEW_TYPEDEFS,COMPARISON_TO_NULL,STRLCPY"
>  options="$options $DPDK_CHECKPATCH_OPTIONS"
>  
>  print_usage () {
> -- 
> 2.30.2
> 


More information about the dev mailing list