[dpdk-dev] [PATCH 28/32] net/ngbe: add IPsec context creation

[Ferruh Yigit]

On 9/8/2021 9:37 AM, Jiawen Wu wrote:
> Initialize securiry context, and support to get security
> capabilities.
> 
> Signed-off-by: Jiawen Wu <jiawenwu at trustnetic.com>

<...>

> --- a/drivers/net/ngbe/ngbe_ethdev.c
> +++ b/drivers/net/ngbe/ngbe_ethdev.c
> @@ -430,6 +430,12 @@ eth_ngbe_dev_init(struct rte_eth_dev *eth_dev, void *init_params __rte_unused)
>  	/* Unlock any pending hardware semaphore */
>  	ngbe_swfw_lock_reset(hw);
>  
> +#ifdef RTE_LIB_SECURITY
> +	/* Initialize security_ctx only for primary process*/
> +	if (ngbe_ipsec_ctx_create(eth_dev))
> +		return -ENOMEM;
> +#endif

Hi Hemant,

I see 'RTE_LIB_SECURITY' is still used in some PMDs, as this new PMD also uses it?
Previously I assume this macro was to mark that security library is enabled, is
this macro still valid? Who should set this macro now?

Also can you please help reviewing this and next a few patches since they are
related to the security?