[PATCH] net/ixgbe: Treat 1G Cu SFPs as 1G SX on the X550 devices

[Wang, Haiyue]

> -----Original Message-----
> From: Thomas Monjalon <thomas at monjalon.net>
> Sent: Thursday, April 14, 2022 17:42
> To: Wang, Haiyue <haiyue.wang at intel.com>
> Cc: Daly, Jeff <jeffd at silicom-usa.com>; dev at dpdk.org; Stephen Douthit <stephend at silicom-usa.com>
> Subject: Re: [PATCH] net/ixgbe: Treat 1G Cu SFPs as 1G SX on the X550 devices
> 
> 14/04/2022 03:31, Wang, Haiyue:
> > From: jeffd at silicom-usa.com <jeffd at silicom-usa.com>
> > > From: Stephen Douthit <stephend at silicom-usa.com>
> > >
> > > 1G Cu SFPs are not officially supported on the X552/X553 family of devices
> > > but treat them as 1G SX modules since they usually work.  Print a warning
> > > though since support isn't validated, similar to what already happens for
> > > other unofficially supported SFPs enabled via the allow_unsupported_sfps
> > > parameter inherited from the mainline Linux driver.
> > >
> > > Signed-off-by: Stephen Douthit <stephend at silicom-usa.com>
> > > Signed-off-by: Jeff Daly <jeffd at silicom-usa.com>
> > > ---
> > >  drivers/net/ixgbe/base/ixgbe_x550.c | 14 +++++++++++++-
> > >  1 file changed, 13 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/net/ixgbe/base/ixgbe_x550.c b/drivers/net/ixgbe/base/ixgbe_x550.c
> > > index 8810d1658e..8d1bc6c80d 100644
> > > --- a/drivers/net/ixgbe/base/ixgbe_x550.c
> > > +++ b/drivers/net/ixgbe/base/ixgbe_x550.c
> > > @@ -1538,9 +1538,21 @@ STATIC s32 ixgbe_supported_sfp_modules_X550em(struct ixgbe_hw *hw, bool
> *linear)
> >
> > NACK.
> >
> > As for 1G Cu SFP treating it as 1G SX, some 1G-Base-T SFP modules require the use
> > of RX_ILOS and some Intel Ethernet products don't support that.
> 
> So what is the solution?
> 
> > And the DPDK keeps the same design with kernel.
> 
> It should not be a justification for limiting DPDK features.

Um, this is upstream version driver to keep the same behavior.

There are also some kind of custom release ...

>