[PATCH v2 3/7] vdpa/mlx5: no kick handling during shutdown

Maxime Coquelin maxime.coquelin at redhat.com
Wed Apr 20 14:37:56 CEST 2022



On 2/24/22 16:50, Xueming Li wrote:
> When Qemu suspend a VM, hw notifier is un-mmapped while vCPU thread may
suspends
> still active and write notifier through kick socket.
still be active

> 
> PMD kick handler thread tries to install hw notifier through client
> socket in such case will timeout and slow down device close.
socket. In such case, it will

> 
> This patch skips hw notifier install if VQ or device in middle of
> shutdown.
> 
> Signed-off-by: Xueming Li <xuemingl at nvidia.com>
> ---
>   drivers/vdpa/mlx5/mlx5_vdpa.c       | 17 ++++++++++-------
>   drivers/vdpa/mlx5/mlx5_vdpa.h       |  8 +++++++-
>   drivers/vdpa/mlx5/mlx5_vdpa_virtq.c | 12 +++++++++++-
>   3 files changed, 28 insertions(+), 9 deletions(-)
> 

Other than the commit messages comments:

Reviewed-by: Maxime Coquelin <maxime.coquelin at redhat.com>

If you are fine with my suggestions and no other revision needed, I can
fixup while applying.

Thanks,
Maxime



More information about the dev mailing list