[PATCH v3 0/2] vhost fixes for OVS SIGSEGV in PMD
Claudio Fontana
cfontana at suse.de
Tue Aug 9 14:39:06 CEST 2022
A weekly ping on this one,
any chance to get this fix for a guest-triggered host crash included?
Thanks,
Claudio
On 8/2/22 02:49, Claudio Fontana wrote:
> This is an alternative, more general fix compared with PATCH v1,
> and fixes style issues in v2.
>
> The series fixes a segmentation fault in the OVS PMD thread when
> resynchronizing with QEMU after the guest application has been killed
> with SIGKILL (patch 1/2),
>
> The segmentation fault can be caused by the guest DPDK application,
> which is able this way to crash the OVS process on the host,
> see the backtrace in patch 1/2.
>
> Patch 2/2 is an additional improvement in the current error handling.
>
> ---
> Changes from v2: fix warnings from checkpatch.
> ---
>
> Changes from v1:
>
> * patch 1/2: instead of only fixing virtio_dev_tx_split, put the check
> for nr_vec == 0 inside desc_to_mbuf and mbuf_to_desc, so that in no
> case they attempt to read and dereference addresses from the buf_vec[]
> array when it does not contain any valid elements.
>
> ---
>
> For your review and comments,
>
> Claudio
>
> Claudio Fontana (2):
> vhost: check for nr_vec == 0 in desc_to_mbuf, mbuf_to_desc
> vhost: improve error handling in desc_to_mbuf
>
> lib/vhost/virtio_net.c | 16 ++++++++++++----
> 1 file changed, 12 insertions(+), 4 deletions(-)
>
More information about the dev
mailing list