[PATCH v2 2/4] event/sw: report periodic event timer capability

[Van Haaren, Harry]

> -----Original Message-----
> From: Carrillo, Erik G <erik.g.carrillo at intel.com>
> Sent: Wednesday, August 10, 2022 9:52 PM
> To: Naga Harish K, S V <s.v.naga.harish.k at intel.com>; jerinj at marvell.com; Van
> Haaren, Harry <harry.van.haaren at intel.com>
> Cc: dev at dpdk.org
> Subject: RE: [PATCH v2 2/4] event/sw: report periodic event timer capability
> 
> Hi Harish,
> 
> > -----Original Message-----
> > From: Naga Harish K, S V <s.v.naga.harish.k at intel.com>
> > Sent: Wednesday, August 10, 2022 2:10 AM
> > To: Carrillo, Erik G <erik.g.carrillo at intel.com>; jerinj at marvell.com; Van
> > Haaren, Harry <harry.van.haaren at intel.com>
> > Cc: dev at dpdk.org
> > Subject: [PATCH v2 2/4] event/sw: report periodic event timer capability
> >
> > update the software eventdev pmd timer_adapter_caps_get callback
> > function to report the support of periodic event timer capability
> >
> > Signed-off-by: Naga Harish K S V <s.v.naga.harish.k at intel.com>
> > ---
> >  drivers/event/sw/sw_evdev.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/event/sw/sw_evdev.c b/drivers/event/sw/sw_evdev.c
> > index f93313b31b..89c07d30ae 100644
> > --- a/drivers/event/sw/sw_evdev.c
> > +++ b/drivers/event/sw/sw_evdev.c
> > @@ -564,7 +564,7 @@ sw_timer_adapter_caps_get(const struct
> > rte_eventdev *dev, uint64_t flags,  {
> >  	RTE_SET_USED(dev);
> >  	RTE_SET_USED(flags);
> > -	*caps = 0;
> > +	*caps = RTE_EVENT_TIMER_ADAPTER_CAP_PERIODIC;

Thanks Harish for the explanation as to why caps are exposed in the Eventdev PMD,
for related timer/etc features, makes sense.

> It looks like we can add:
> 
> #define RTE_EVENT_TIMER_ADAPTER_SW_CAP \
> 	RTE_EVENT_TIMER_ADAPTER_CAP_PERIODIC
> 
> to eventdev_pmd.h (the same as RTE_EVENT_CRYPTO_ADAPTER_SW_CAP, for
> example),
> 
> and use that definition here, and in rte_event_timer_adapter_caps_get().
> 
> Thanks,
> Erik

Erik, I like the suggestion of a standardized set of "generic SW" caps flags at the Eventdev level,
and then all SW based PMDs can use that #define, avoids each new cap needing changes in multiple drivers.

Good work, -Harry