[PATCH v3 1/4] eventdev/timer: add periodic event timer support
Carrillo, Erik G
erik.g.carrillo at intel.com
Thu Aug 11 21:22:24 CEST 2022
Hi Harish,
> -----Original Message-----
> From: Naga Harish K, S V <s.v.naga.harish.k at intel.com>
> Sent: Thursday, August 11, 2022 10:37 AM
> To: Carrillo, Erik G <erik.g.carrillo at intel.com>; jerinj at marvell.com
> Cc: pbhagavatula at marvell.com; sthotton at marvell.com; dev at dpdk.org
> Subject: [PATCH v3 1/4] eventdev/timer: add periodic event timer support
>
> This patch adds support to configure and use periodic event timers in
> software timer adapter.
>
> The structure ``rte_event_timer_adapter_stats`` is extended by adding a
> new field, ``evtim_drop_count``. This stat represents the number of times an
> event_timer expiry event is dropped by the event timer adapter.
>
> Signed-off-by: Naga Harish K S V <s.v.naga.harish.k at intel.com>
> ---
<... snipped ...>
> diff --git a/lib/eventdev/rte_eventdev.c b/lib/eventdev/rte_eventdev.c
> index 1dc4f966be..4a2a1178da 100644
> --- a/lib/eventdev/rte_eventdev.c
> +++ b/lib/eventdev/rte_eventdev.c
> @@ -139,7 +139,11 @@ rte_event_timer_adapter_caps_get(uint8_t dev_id,
> uint32_t *caps)
>
> if (caps == NULL)
> return -EINVAL;
> - *caps = 0;
> +
> + if (dev->dev_ops->timer_adapter_caps_get == NULL)
> + *caps = RTE_EVENT_TIMER_ADAPTER_CAP_PERIODIC;
I think we should move the definition of RTE_EVENT_TIMER_ADAPTER_SW_CAP to this patch, and use that macro here as well. With that change, this looks good to me.
Thanks,
Erik
> + else
> + *caps = 0;
>
> return dev->dev_ops->timer_adapter_caps_get ?
> (*dev->dev_ops-
> >timer_adapter_caps_get)(dev,
> --
> 2.25.1
More information about the dev
mailing list