[PATCH] net/ice: add devargs for disabling mac filter

Zhang, Ke1X ke1x.zhang at intel.com
Tue Dec 13 06:43:17 CET 2022


Hi Stephen:

Thanks for your comments.
I just follow the definition of other variables like pipe_mode_support, safe_mode_support.
And when I run the testpmd , I could write the command like this:

./dpdk-testpmd -l 16-32 -a ca:00.0,mac-filter-disable=1 -a ca:00.1 -- -i
The value could 1 or 0.

Would you please give me some guidance about the definition of the variable?

BR
Zhang Ke

> -----Original Message-----
> From: Stephen Hemminger <stephen at networkplumber.org>
> Sent: Tuesday, December 13, 2022 11:51 AM
> To: Zhang, Ke1X <ke1x.zhang at intel.com>
> Cc: Zhang, Qi Z <qi.z.zhang at intel.com>; Zhang, Yuying
> <yuying.zhang at intel.com>; dev at dpdk.org
> Subject: Re: [PATCH] net/ice: add devargs for disabling mac filter
> 
> On Fri, 25 Nov 2022 10:51:24 +0800
> Ke Zhang <ke1x.zhang at intel.com> wrote:
> 
> > diff --git a/drivers/net/ice/ice_ethdev.h
> > b/drivers/net/ice/ice_ethdev.h index c8311be179..0350c6584a 100644
> > --- a/drivers/net/ice/ice_ethdev.h
> > +++ b/drivers/net/ice/ice_ethdev.h
> > @@ -563,6 +563,7 @@ struct ice_devargs {
> >  	int safe_mode_support;
> >  	uint8_t proto_xtr_dflt;
> >  	int pipe_mode_support;
> > +	int mac_filter_disable;
> 
> Why use 4 bytes for a flag when a single bit would do.


More information about the dev mailing list