[PATCH v1] drivers: fix incorrect E-Switch manager vport ID

Raslan Darawsheh rasland at nvidia.com
Thu Feb 24 10:20:40 CET 2022


Hi,

> -----Original Message-----
> From: Ferruh Yigit <ferruh.yigit at intel.com>
> Sent: Wednesday, February 23, 2022 9:00 PM
> To: Raslan Darawsheh <rasland at nvidia.com>; Shun Hao
> <shunh at nvidia.com>; Matan Azrad <matan at nvidia.com>; Slava Ovsiienko
> <viacheslavo at nvidia.com>; Ori Kam <orika at nvidia.com>; NBU-Contact-
> Thomas Monjalon (EXTERNAL) <thomas at monjalon.net>; Xueming(Steven)
> Li <xuemingl at nvidia.com>
> Cc: dpdk-dev <dev at dpdk.org>; stable at dpdk.org
> Subject: Re: [PATCH v1] drivers: fix incorrect E-Switch manager vport ID
> 
> On 2/23/2022 2:39 PM, Raslan Darawsheh wrote:
> > Hi,
> >
> >> -----Original Message-----
> >> From: Shun Hao <shunh at nvidia.com>
> >> Sent: Tuesday, February 22, 2022 5:07 PM
> >> To: Matan Azrad <matan at nvidia.com>; Slava Ovsiienko
> >> <viacheslavo at nvidia.com>; orika at nvidia.com ; thomas at monjalon.net ;
> >> Xueming(Steven) Li <xuemingl at nvidia.com>
> >> Cc: dev at dpdk.org ; Raslan Darawsheh <rasland at nvidia.com>;
> >> stable at dpdk.org
> >> Subject: [PATCH v1] drivers: fix incorrect E-Switch manager vport ID
> >>
> >> One of the E-Switch vports plays the special role - it is assigned as
> >> "E-Switch manager" and has some special exclusive rights and duties -
> >> it maintains all the representors, manages FDB domain flows, etc. By
> >> default, the E-Switch vport index was supposed to be zero on
> >> standalone NICs (regular ConnectX) and 0xFFFE SmartNIC (BlueField),
> >> but that was not always correct - this index can be assigned with any value
> by kernel/hypervisor.
> >>
> >> Currently the E-Switch manager vport id is supposed to be default - 0
> >> for standalone NICs, and 0xFFFE for the SmartNICs, and is deduced
> >> from the device PCI id.
> >>
> >> To handle this and do not suggest any default values, can use DevX
> >> API to query E-Switch manager vport ID directly from the firmware
> >> during initialization, and use that value by default. If the new
> >> method is not provided (legacy firmware), fallback to use the PCI id
> approach.
> >>
> >> Fixes: a564038699f9 ("net/mlx5: support E-Switch manager egress
> >> traffic
> >> match")
> >> Cc: stable at dpdk.org
> >>
> >> Signed-off-by: Shun Hao <shunh at nvidia.com>
> >> Acked-by: Viacheslav Ovsiienko <viacheslavo at nvidia.com>
> >
> > Patch applied to next-net-mlx,
> >
> 
> Hi Raslan,
> 
> Can you make a patch to add 'E-Switch' keyword to './devtools/words-
> case.txt', in the syntax how it suppose to be? (There are various variants of it
> in the commit history.)

Sure, will send a patch for it, and I think the correct syntax should be E-Switch as written in this patch.

Kindest regards,
Raslan Darawsheh


More information about the dev mailing list