[PATCH v2 9/9] vhost: use proper logging type for data path

Xia, Chenbo chenbo.xia at intel.com
Wed Jan 26 04:27:08 CET 2022


> -----Original Message-----
> From: Maxime Coquelin <maxime.coquelin at redhat.com>
> Sent: Tuesday, January 25, 2022 7:25 PM
> To: dev at dpdk.org; Xia, Chenbo <chenbo.xia at intel.com>;
> david.marchand at redhat.com
> Cc: Maxime Coquelin <maxime.coquelin at redhat.com>
> Subject: [PATCH v2 9/9] vhost: use proper logging type for data path
> 
> This patch changes type from config to data for functions
> called in the datapath.
> 
> Suggested-by: David Marchand <david.marchand at redhat.com>
> Signed-off-by: Maxime Coquelin <maxime.coquelin at redhat.com>
> ---
>  lib/vhost/vhost.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/lib/vhost/vhost.c b/lib/vhost/vhost.c
> index cd62dc238b..f59ca6c157 100644
> --- a/lib/vhost/vhost.c
> +++ b/lib/vhost/vhost.c
> @@ -58,7 +58,7 @@ __vhost_iova_to_vva(struct virtio_net *dev, struct
> vhost_virtqueue *vq,
> 
>  		vhost_user_iotlb_pending_insert(dev, vq, iova, perm);
>  		if (vhost_user_iotlb_miss(dev, iova, perm)) {
> -			VHOST_LOG_CONFIG(ERR, "(%s) IOTLB miss req failed for IOVA
> 0x%" PRIx64 "\n",
> +			VHOST_LOG_DATA(ERR, "(%s) IOTLB miss req failed for IOVA
> 0x%" PRIx64 "\n",
>  				dev->ifname, iova);
>  			vhost_user_iotlb_pending_remove(vq, iova, 1, perm);
>  		}
> @@ -420,7 +420,7 @@ translate_log_addr(struct virtio_net *dev, struct
> vhost_virtqueue *vq,
> 
>  		gpa = hva_to_gpa(dev, hva, exp_size);
>  		if (!gpa) {
> -			VHOST_LOG_CONFIG(ERR,
> +			VHOST_LOG_DATA(ERR,
>  				"(%s) failed to find GPA for log_addr: 0x%"
>  				PRIx64 " hva: 0x%" PRIx64 "\n",
>  				dev->ifname, log_addr, hva);
> --
> 2.34.1

Reviewed-by: Chenbo Xia <chenbo.xia at intel.com>


More information about the dev mailing list