[PATCH] doc: announce some raw/ifpga API removal

Huang, Wei wei.huang at intel.com
Fri Jul 1 09:16:31 CEST 2022



> -----Original Message-----
> From: David Marchand <david.marchand at redhat.com>
> Sent: Friday, July 1, 2022 15:01
> To: Huang, Wei <wei.huang at intel.com>; Xu, Rosen <rosen.xu at intel.com>;
> Zhang, Tianfei <tianfei.zhang at intel.com>
> Cc: dev at dpdk.org; Ray Kinsella <mdr at ashroe.eu>
> Subject: Re: [PATCH] doc: announce some raw/ifpga API removal
> 
> On Fri, Jul 1, 2022 at 8:25 AM Huang, Wei <wei.huang at intel.com> wrote:
> > > >
> > > > rte_pmd_ifpga_get_pci_bus() documentation is vague and it is
> > > > unclear what could be done with it.
> > > > On the other hand, EAL provides a standard API to retrieve a bus
> > > > object by name.
> > > >
> > Agree, this API is used in an external application, I can use
> rte_get_bus_by_name() to replace it.
> 
> What is the PCI bus used for, in this application?
> 
In this application, target PCI device is Intel FPGA, it supports some special operation like removing it from PCI bus and rescanning it back from PCI bus,
So there are two things need to be done directly on rte_pci_bus:
1. Rescan PCI bus
     pci_bus->bus.scan()
2. Get pci_dev by specified PCI address, and remove it
    TAILQ_FOREACH(pci_dev, &pci_bus->device_list, next) {
	if (!rte_pci_addr_cmp(&pci_dev->addr, &addr))
		return pci_dev;
    }
    ....
    pci_drv = pci_dev->driver;
    pci_drv->remove(pci_dev);
> 
> > I will submit a patch to remove rte_pmd_ifpga_get_pci_bus() after DPDK22.07
> is released.
> 
> I sent a patch a few days ago:
> https://patches.dpdk.org/project/dpdk/patch/20220628144643.1213026-3-
> david.marchand at redhat.com/
> 
> 
> --
> David Marchand



More information about the dev mailing list