[PATCH v4 0/4] clean up zero-length arrays

Tyler Retzlaff roretzla at linux.microsoft.com
Thu Jun 9 17:19:24 CEST 2022


does this mean we now *require* a C99 compiler?

(which i have no problem with)

Series-acked-by: Tyler Retzlaff <roretzla at linux.microsoft.com>

On Fri, Jun 03, 2022 at 12:16:21PM +0100, Bruce Richardson wrote:
> This patchset adds a coccinelle script to clean-up zero-length
> arrays in structures. The final patches are the result of running
> that script on the DPDK repository.
> 
> V4: removed change from struct ipsec_encap_pdb in common/dpaax, which
>     caused build errors
> 
> V3: Fixed issues in mlx5 drivers:
>   * fixed incorrect coccinelle replacement of 2-D zero-length arrays
>   * undid removal of "0" in tx elts[] which caused issues with Werror-pedantic
> 
> V2: rebased to fix apply conflict
> 
> Bruce Richardson (4):
>   cocci: add script for zero-length arrays in structs
>   drivers: replace zero-length arrays with undimensioned ones
>   lib: replace zero-length arrays with undimensioned ones
>   app: examples: replace zero-length arrays with undimensioned ones
> 
>  app/test/test_table_tables.c                  |  2 +-
>  devtools/cocci/zero_length_array.cocci        | 21 +++++++++++++++++++
>  drivers/bus/dpaa/include/netcfg.h             |  4 ++--
>  drivers/bus/vmbus/rte_vmbus_reg.h             |  4 ++--
>  drivers/common/cnxk/roc_se.h                  |  2 +-
>  drivers/common/dpaax/dpaax_iova_table.h       |  2 +-
>  drivers/common/mlx5/mlx5_prm.h                | 10 ++++-----
>  drivers/crypto/ipsec_mb/ipsec_mb_private.h    |  4 ++--
>  drivers/crypto/virtio/virtio_ring.h           |  4 ++--
>  drivers/crypto/virtio/virtqueue.h             |  2 +-
>  drivers/net/atlantic/hw_atl/hw_atl_utils.h    |  2 +-
>  drivers/net/cxgbe/clip_tbl.h                  |  2 +-
>  drivers/net/cxgbe/l2t.h                       |  2 +-
>  drivers/net/cxgbe/mps_tcam.h                  |  2 +-
>  drivers/net/cxgbe/smt.h                       |  2 +-
>  drivers/net/enic/base/vnic_devcmd.h           |  2 +-
>  drivers/net/hinic/hinic_pmd_tx.h              |  2 +-
>  drivers/net/nfp/nfpcore/nfp_nsp.h             |  2 +-
>  drivers/net/virtio/virtio_ring.h              |  4 ++--
>  drivers/net/virtio/virtio_user/vhost_kernel.c |  2 +-
>  drivers/net/virtio/virtio_user/vhost_vdpa.c   |  2 +-
>  drivers/net/virtio/virtqueue.h                |  2 +-
>  drivers/regex/mlx5/mlx5_rxp.h                 |  4 ++--
>  examples/ip_reassembly/main.c                 |  2 +-
>  examples/ptpclient/ptpclient.c                |  4 ++--
>  lib/cryptodev/cryptodev_pmd.h                 |  2 +-
>  lib/cryptodev/rte_cryptodev.h                 |  2 +-
>  lib/eventdev/rte_event_timer_adapter.h        |  2 +-
>  lib/ip_frag/ip_reassembly.h                   |  2 +-
>  lib/ipsec/sa.h                                |  2 +-
>  lib/rib/rte_rib.c                             |  2 +-
>  lib/rib/rte_rib6.c                            |  2 +-
>  lib/table/rte_swx_table_learner.c             |  4 ++--
>  lib/table/rte_table_hash_key16.c              |  4 ++--
>  lib/table/rte_table_hash_key32.c              |  4 ++--
>  lib/table/rte_table_hash_key8.c               |  4 ++--
>  lib/vhost/rte_vhost.h                         |  4 ++--
>  37 files changed, 73 insertions(+), 52 deletions(-)
>  create mode 100644 devtools/cocci/zero_length_array.cocci
> 
> --
> 2.34.1


More information about the dev mailing list