[PATCH] crypto/ipsec_mb: enable compilation for non x86 arch

Zhang, Roy Fan roy.fan.zhang at intel.com
Fri Jun 17 12:23:26 CEST 2022


Hi,

IPsec-mb PMD should not be built at all if the library is not installed.
Also, the code you are warping with macro only prevents initializing the vector mode param to SSE which is later used to add feature flag bits. To me this change does not make much sense.
Can you share with me the purpose of this change?

Regards,
Fan

> -----Original Message-----
> From: Ashwin Sekhar T K <asekhar at marvell.com>
> Sent: Friday, June 10, 2022 5:21 PM
> To: dev at dpdk.org
> Cc: jerinj at marvell.com; skori at marvell.com; skoteshwar at marvell.com;
> pbhagavatula at marvell.com; kirankumark at marvell.com;
> psatheesh at marvell.com; asekhar at marvell.com; anoobj at marvell.com;
> gakhil at marvell.com; hkalra at marvell.com; ndabilpuram at marvell.com
> Subject: [PATCH] crypto/ipsec_mb: enable compilation for non x86 arch
> 
> Enable compilation for non x86 architectures by conditionally
> compiling x86 specific code.
> 
> Signed-off-by: Ashwin Sekhar T K <asekhar at marvell.com>
> ---
>  drivers/crypto/ipsec_mb/ipsec_mb_private.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/crypto/ipsec_mb/ipsec_mb_private.c
> b/drivers/crypto/ipsec_mb/ipsec_mb_private.c
> index aab42c360c..9ea1110aaf 100644
> --- a/drivers/crypto/ipsec_mb/ipsec_mb_private.c
> +++ b/drivers/crypto/ipsec_mb/ipsec_mb_private.c
> @@ -53,6 +53,7 @@ ipsec_mb_create(struct rte_vdev_device *vdev,
>  	const char *name, *args;
>  	int retval;
> 
> +#ifdef RTE_ARCH_X86_64
>  	if (vector_mode == IPSEC_MB_NOT_SUPPORTED) {
>  		/* Check CPU for supported vector instruction set */
>  		if (rte_cpu_get_flag_enabled(RTE_CPUFLAG_AVX512F))
> @@ -64,6 +65,7 @@ ipsec_mb_create(struct rte_vdev_device *vdev,
>  		else
>  			vector_mode = IPSEC_MB_SSE;
>  	}
> +#endif
> 
>  	init_params.private_data_size = sizeof(struct ipsec_mb_dev_private) +
>  		pmd_data->internals_priv_size;
> --
> 2.25.1



More information about the dev mailing list