[Bug 942] i40e: condition in `i40e_flow_parse_fdir_pattern()` is always false
bugzilla at dpdk.org
bugzilla at dpdk.org
Tue Mar 1 07:59:18 CET 2022
https://bugs.dpdk.org/show_bug.cgi?id=942
Bug ID: 942
Summary: i40e: condition in `i40e_flow_parse_fdir_pattern()` is
always false
Product: DPDK
Version: 21.11
Hardware: All
OS: All
Status: UNCONFIRMED
Severity: normal
Priority: Normal
Component: ethdev
Assignee: dev at dpdk.org
Reporter: Stepan.Repin at infotecs.ru
Target Milestone: ---
`i40e_flow.c` contains the following code processing `RTE_FLOW_ITEM_TYPE_ETH`
in the function
`i40e_flow_parse_fdir_pattern()` [1]:
if (eth_spec && eth_mask && next_type == RTE_FLOW_ITEM_TYPE_END) {
...
if (next_type == RTE_FLOW_ITEM_TYPE_VLAN || ...) {
...
}
}
Clearly, that condition in the inner "if" is always "false". Before commit
ea0c22fd [2] outer "if" was:
if (eth_spec && eth_mask && eth_mask->type) { ...
Please clarify, is there really an error?
[1]: http://git.dpdk.org/dpdk/tree/drivers/net/i40e/i40e_flow.c#n2448
[2]:
http://git.dpdk.org/dpdk/commit/drivers/net/i40e?id=ea0c22fd8227a3ac3507984ff766d66355a3651e
--
You are receiving this mail because:
You are the assignee for the bug.
More information about the dev
mailing list