[PATCH] app/pdump: close program if --pdump argument is missing

Usman Tanveer usman.tanveer at emumba.com
Thu Mar 31 14:59:03 CEST 2022


The 20.11 release is not coming out till August, in the meantime, this
patch can be applied to print help if mandatory argument is not
passed.


On Wed, Mar 2, 2022 at 9:52 PM Stephen Hemminger
<stephen at networkplumber.org> wrote:
>
> On Wed,  2 Mar 2022 14:26:14 +0500
> "usman.tanveer" <usman.tanveer at emumba.com> wrote:
>
> > --pdump is a mandatory argument in pdump application.
> > It should print usage and exit if --pdump argument
> > is missing. The application is not closing and getting
> > stuck. Made the change to print usage and exit when
> > this argument is missing.
> >
> > Signed-off-by: usman.tanveer <usman.tanveer at emumba.com>
>
> Maybe pdump could just do something sane with no arguments.
> That is one of the issues I tried to address by rewriting it.
>
> Ideally, existing pdump can be deprecated and removed in 22.11?


More information about the dev mailing list