[dpdk-dev] [PATCH v4] ethdev: mtr: support protocol based input color selection

[Jerin Jacob]

On Tue, Apr 26, 2022 at 3:49 PM Ray Kinsella <mdr at ashroe.eu> wrote:
>
>
> jerinj at marvell.com writes:
>
> > From: Jerin Jacob <jerinj at marvell.com>
> >
> > Currently, meter object supports only DSCP based on input color table,
> > The patch enhance that to support VLAN based input color table,
> > color table based on inner field for the tunnel use case, and
> > support for fallback color per meter if packet based on a different field.
> >
> > All of the above features are exposed through capability and added
> > additional capability to specify the implementation supports
> > more than one input color table per ethdev port.
> >
> > Suggested-by: Cristian Dumitrescu <cristian.dumitrescu at intel.com>
> > Signed-off-by: Jerin Jacob <jerinj at marvell.com>
> > ---
> > v4..v3:
> >
> > - Aligned with community meeting call which is documented in
> > https://patches.dpdk.org/project/dpdk/patch/20220301085824.1041009-1-skori@marvell.com/
> > as last message. With following exception,
> > - Used RTE_MTR_COLOR_IN_*_DSCP instead of RTE_MTR_COLOR_IN_*_IP as
> > there is already dscp_table and rte_mtr_meter_dscp_table_update() API.
> > Changing above symbols break existing application for no good.
> > - Updated 22.07 release notes
> > - Remove testpmd changes from series to finalize the API spec first and
> >   then we can send testpmd changes.
> >
> > v3..v2:
> >
> > - Fix input color flags as a bitmask
> > - Add definitions for newly added API
> >
> > v2..v1:
> > - Fix seperate typo
> >
> > v1..RFC:
> >
> > Address the review comments by Cristian at
> > https://patches.dpdk.org/project/dpdk/patch/20210820082401.3778736-1-jerinj@marvell.com/

> >
> > diff --git a/lib/ethdev/version.map b/lib/ethdev/version.map
> > index 20391ab29e..cccbf6dee5 100644
> > --- a/lib/ethdev/version.map
> > +++ b/lib/ethdev/version.map
> > @@ -279,6 +279,10 @@ EXPERIMENTAL {
> >       rte_flow_async_action_handle_create;
> >       rte_flow_async_action_handle_destroy;
> >       rte_flow_async_action_handle_update;
> > +
> > +     # added in 22.07
>
> Symbols are not in alphabetical order.

Thanks. Will fix it in  v5

>
> > +     rte_mtr_meter_vlan_table_update;
> > +     rte_mtr_color_in_protocol_priority_set;
> >  };
> >
> >  INTERNAL {
>
>
> --
> Regards, Ray K