[PATCH v8 1/2] hash: split x86 and SW hash CRC intrinsics

Wang, Yipeng1 yipeng1.wang at intel.com
Wed May 4 04:19:17 CEST 2022


> -----Original Message-----
> From: Pavan Nikhilesh <pbhagavatula at marvell.com>
> Sent: Friday, April 29, 2022 9:17 AM
> To: ruifeng.wang at arm.com; Wang, Yipeng1 <yipeng1.wang at intel.com>;
> Gobriel, Sameh <sameh.gobriel at intel.com>; Richardson, Bruce
> <bruce.richardson at intel.com>; Medvedkin, Vladimir
> <vladimir.medvedkin at intel.com>
> Cc: jerinj at marvell.com; dev at dpdk.org; Pavan Nikhilesh
> <pbhagavatula at marvell.com>
> Subject: [PATCH v8 1/2] hash: split x86 and SW hash CRC intrinsics
> 
> Split x86 and SW hash crc intrinsics into a separate files.
> 
> Signed-off-by: Pavan Nikhilesh <pbhagavatula at marvell.com>
> Reviewed-by: Ruifeng Wang <ruifeng.wang at arm.com>
> ---
>  v8 Changes:
>  - Install arch specific headers as indirect headers.
>  - Retain `rte` prefix for arch specific headers.
>  v7 Changes:
>  - Fix build with ppc and other arch.
>  v6 Changes:
>  - Simplify rte_hash_crc_set_alg function. (Ruifeng)
>  v5 Changes:
>  - Move CRC functions to implementation specific files to remove
>    ifdef clutter. (Ruifeng)
> 
[Wang, Yipeng]
Looks good to me and I believe it is more organized now than before. Thanks for the patch!
I did not fully test on x86 though, will rely on the CI or any other reviewer's input.

A little bit grammar issue in commit message: "into separate files"
 
Acked-by: Yipeng Wang <yipeng1.wang at intel.com>


More information about the dev mailing list