[RFC PATCH v2 1/5] app/testpmd: mark cmdline symbols as static
Andrew Rybchenko
andrew.rybchenko at oktetlabs.ru
Fri May 20 08:28:05 CEST 2022
On 5/18/22 22:46, David Marchand wrote:
> All those symbols don't need to be global, plus it hides unused code
> such as cmd_set_conntrack_dir_set and cmd_set_conntrack_dir_conntrack
> tokens.
>
> Signed-off-by: David Marchand <david.marchand at redhat.com>
Very good idea. A couple of days ago I was wondering why these
symbols are global when I found few unused symbols in mtr
commands: cmd_create_port_meter_g_action,
cmd_create_port_meter_y_action and
cmd_create_port_meter_r_action.
So, it would be good to apply it to other similar files as
well.
Acked-by: Andrew Rybchenko <andrew.rybchenko at oktetlabs.ru>
More information about the dev
mailing list