[PATCH v2] usertools/hugepages: show usage if no action specified

Thomas Monjalon thomas at monjalon.net
Tue Nov 22 16:32:38 CET 2022


Previously, the script was doing nothing if no argument was provided.

If neither show, mount/unmount, clear/reserve are specified,
it is assumed that the user does not know how to use the script.
So the usage and an error message are printed.
The exit code will be non-zero.
The user will understand something is wrong,
and can recall the script with the option -h to get more information.

Signed-off-by: Thomas Monjalon <thomas at monjalon.net>
---
v2: replace parser.print_usage() and sys.exit(1) with parser.error()
---
 usertools/dpdk-hugepages.py | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/usertools/dpdk-hugepages.py b/usertools/dpdk-hugepages.py
index a22d504d3a..bf2575ba36 100755
--- a/usertools/dpdk-hugepages.py
+++ b/usertools/dpdk-hugepages.py
@@ -272,6 +272,9 @@ def main():
         args.reserve = args.setup
         args.mount = True
 
+    if not (args.show or args.mount or args.unmount or args.clear or args.reserve):
+        parser.error("no action specified")
+
     if args.pagesize:
         pagesize_kb = get_memsize(args.pagesize)
     else:
-- 
2.36.1



More information about the dev mailing list