[PATCH v7 2/3] timer: fix function to stop all timers

Thomas Monjalon thomas at monjalon.net
Wed Oct 5 14:59:44 CEST 2022


> > On Wed, Sep 14, 2022 at 9:03 PM Naga Harish K S V
> > <s.v.naga.harish.k at intel.com> wrote:
> > >
> > > There is a possibility of deadlock in this API, as same spinlock is
> > > tried to be acquired in nested manner.
> > >
> > > If the lcore that is stopping the timer is different from the lcore
> > > that owns the timer, the timer list lock is acquired in timer_del(),
> > > even if local_is_locked is true. Because the same lock was already
> > > acquired in rte_timer_stop_all(), the thread will hang.
> > >
> > > This patch removes the acquisition of nested lock.
> > >
> > > Fixes: 821c51267bcd63a ("timer: add function to stop all timers in a
> > > list")
> > > Cc: stable at dpdk.org
> > >
> > > Signed-off-by: Naga Harish K S V <s.v.naga.harish.k at intel.com>
> Acked-by: Erik Gabriel Carrillo <erik.g.carrillo at intel.com>
> 
> Added missing ack

Applied, thanks.





More information about the dev mailing list