[PATCH v2 1/4] ethdev: add trace points

[Andrew Rybchenko]

On 9/29/22 13:29, Ankur Dwivedi wrote:
> Add trace points for ethdev functions.
> 
> Signed-off-by: Ankur Dwivedi <adwivedi at marvell.com>

[snip]

> @@ -5867,6 +6010,7 @@ rte_eth_rx_metadata_negotiate(uint16_t port_id, uint64_t *features)
>   {
>   	struct rte_eth_dev *dev;
>   
> +	rte_eth_trace_rx_metadata_negotiate(port_id, features);

features are in/out, so it would be interesting to values,
not just pointer and both values: input and output.

>   	RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
>   	dev = &rte_eth_devices[port_id];
>   

[snip]

> diff --git a/lib/ethdev/version.map b/lib/ethdev/version.map
> index 3def7bfd24..e3d603cc9a 100644
> --- a/lib/ethdev/version.map
> +++ b/lib/ethdev/version.map
> @@ -288,6 +288,150 @@ EXPERIMENTAL {
>   
>   	# added in 22.11
>   	rte_flow_async_action_handle_query;
> +	__rte_eth_trace_add_first_rx_callback;

Why is it in EXPERIMENTAL section, but not INTERNAL?

[snip]

>   INTERNAL